-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
@jreback ping. This updates |
so master needs to be updated to remove 2.7 support |
yes, i think daily is OK (modulo periodic breakages due to churn on pandas master). I removed the 2.7 builds, and reordered the build matrix similar to I kept the 3.5 32b linux build, even though its not on I'll sanity test the mac wheels locally once they've built. |
@jreback the 3 macos wheels from my fork install OK for me locally. All builds have a string of
and
|
The version of pytest being picked up (3.8.2) is quite old. That may be the source of the collection error. That's being set at https://github.com/MacPython/pandas-wheels/blob/master/.travis.yml#L87. |
I'd prefer to move this setting to pandas. We should have an |
I already opened pandas-dev/pandas#25593 for that :) I'll make a PR to pandas, and we can use it here. |
Sure, but that shouldn’t block this PR from being merged, should it? Let me know if I need to do anything more here |
The tests aren't actually being run right now. https://travis-ci.org/MacPython/pandas-wheels/jobs/549413737#L4004 I'll make another PR updating the pytest install and then we can re-run this on top. |
Now you mention that, I do remember thinking the wheels were building quite a bit quicker than I remembered...-:) |
@TomAugspurger I can get most of the tests running on master by allowing
2.7 linux 64b
2.7 linux 32b
|
Sorry for the delay. Looking now. We don't need to worry about 2.7 anymore. |
Whoops, I didn't realize this was also syncing master with daily. I did that over in #53 @robbuckley can you confirm that things look OK on master now? We have |
@TomAugspurger no problem. The Also, you have removed the linux py35 32b build, is that intentional? It was added to master fairly recemtly, in #35 Everything else looks good. |
I built wheels off the current master, and confirmed the mac ones are wrong (they are all 10.6+ dual arch). I've rebased and pushed the |
ping @TomAugspurger @jreback, any chance of getting this merged? |
Thanks. I'll followup on your comment in #48 (comment) |
resolves #42 for master
cherry pick from daily 978fdc2
also align build matrix with daily