-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
I'd like to get rid of the daily branch. Does anyone know of a way to make a kind of "conditional environment variable" in travis. Basically, we have
I'd like that to be
|
@TomAugspurger why do you need that we could just set (after released 0.25.0); BUILD_COMMIT=master (or empty) |
- BUILD_COMMIT=$BUILD_COMMIT; | ||
- BUILD_DEPENDS="$NP_BUILD_DEP Cython==0.28.2" | ||
# binary-only for cryptogrpahy. See https://github.com/pandas-dev/pandas/issues/26589 | ||
# Moto picks it up, and they don't distribute 32-bit wheels. | ||
- TEST_DEPENDS="$NP_TEST_DEP pytest==3.8.2 pytest-xdist pytest-mock moto hypothesis wheel==0.31.1 cryptography --only-binary=cryptography" | ||
- TEST_DEPENDS="$NP_TEST_DEP pytest>=4.0.2 pytest-xdist pytest-mock moto hypothesis>=3.58 wheel==0.31.1 cryptography --only-binary=cryptography" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might need <5.0.0 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
though we are not running the slow tests so not sure.
Your comment made me realize an issue with my request. We may need different matrix items, deps, etc for the maintainace branch. The best may be to do what you say, but make a |
what don’t u like about the current setup? |
My hope was to not have daily & master drift so far apart, but I think that's unavoidable. We'll always need to have the maintenance branch (whether that's called "master" or 0.25.x) be behind. |
All green. Merging. |
Syncs with daily.