refactor: cleanup response to remove singleton accessors (except text) #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
v2-docs | c531f58 | Commit Preview URL | Jul 31 2025, 09:36 PM |
This was referenced Jul 30, 2025
Collaborator
Author
teamdandelion
force-pushed
the
07-29-refactor_cleanup_response_to_remove_singleton_accessors_except_text_
branch
from
481ccea to
74e31b9
Compare
teamdandelion
force-pushed
the
07-29-refactor_cleanup_response_to_remove_singleton_accessors_except_text_
branch
from
74e31b9 to
adcac3c
Compare
teamdandelion
force-pushed
the
07-29-feat_add_tool.__call___rename_tool.call_to_tool.execute_
branch
2 times, most recently
from
815cd5c to
52f4413
Compare
teamdandelion
force-pushed
the
07-29-refactor_cleanup_response_to_remove_singleton_accessors_except_text_
branch
2 times, most recently
from
c6d3765 to
ae50177
Compare
This was referenced Jul 30, 2025
teamdandelion
force-pushed
the
07-29-feat_add_tool.__call___rename_tool.call_to_tool.execute_
branch
from
52f4413 to
a30e652
Compare
teamdandelion
force-pushed
the
07-29-refactor_cleanup_response_to_remove_singleton_accessors_except_text_
branch
from
ae50177 to
09b5059
Compare
willbakst
approved these changes
Jul 31, 2025
teamdandelion
force-pushed
the
07-29-refactor_cleanup_response_to_remove_singleton_accessors_except_text_
branch
from
09b5059 to
5bef656
Compare
teamdandelion
force-pushed
the
07-29-feat_add_tool.__call___rename_tool.call_to_tool.execute_
branch
from
a30e652 to
31dc882
Compare
Collaborator
Author
Merge activity
|
teamdandelion
changed the base branch from
07-29-feat_add_tool.__call___rename_tool.call_to_tool.execute_
to
graphite-base/1154
teamdandelion
force-pushed
the
07-29-refactor_cleanup_response_to_remove_singleton_accessors_except_text_
branch
from
5bef656 to
c531f58
Compare
teamdandelion
deleted the
07-29-refactor_cleanup_response_to_remove_singleton_accessors_except_text_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In offline discussion, we agreed that having the singleton accessors for non-text content is a questionable affordance, users can write
.images[0]if that's really what they want, and it is clearer that they may be skipping some. In particularresponse.tool_callencourages writing bad code that will miss parallel tool calling.In the case of the
textproperty, I updated docstring to show that it returns empty string if there is no text, and added a delimiter argument that defaults to\nfor concatenating multiple text pieces.Also removed cost tracking from response and stream.