Skip to content

Get rid of OutputFormat::get() and ::set() #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
oliverklee opened this issue Mar 6, 2025 · 0 comments · Fixed by #1110
Closed
4 tasks done

Get rid of OutputFormat::get() and ::set() #1103

oliverklee opened this issue Mar 6, 2025 · 0 comments · Fixed by #1110
Assignees
@oliverklee
Milestone
9.0.0: Drop suppo...

Comments

@oliverklee
Copy link
Collaborator

oliverklee commented Mar 6, 2025 •
edited
Loading

  • deprecate both in V8.x
  • drop the (unused) get()
  • rework OutputFormatTest to not use set() anymore
  • drop set()
@oliverklee oliverklee self-assigned this Mar 7, 2025
oliverklee added a commit that referenced this issue Mar 7, 2025
@oliverklee
[CLEANUP] Use the explicit OutputFormat setters in the tests
0fcad40 
The `set()` method will be removed soon.

Also unify the tests a bit.

Part of #1103
@oliverklee oliverklee mentioned this issue Mar 7, 2025
Merged
oliverklee added a commit that referenced this issue Mar 7, 2025
@oliverklee
[TASK] Deprecate OutputFormat::get() and ::set()
8acbf2d 
Part of #1103
@oliverklee oliverklee mentioned this issue Mar 7, 2025
Merged
oliverklee added a commit that referenced this issue Mar 7, 2025
@oliverklee
[CLEANUP] Use the explicit OutputFormat setters in the tests
9eb4feb 
The `set()` method will be removed soon.

Also unify the tests a bit.

Part of #1103
oliverklee added a commit that referenced this issue Mar 7, 2025
@oliverklee
[CLEANUP] Use the explicit OutputFormat setters in the tests
504e142 
The `set()` method will be removed soon.

Also unify the tests a bit.

Part of #1103
oliverklee added a commit that referenced this issue Mar 7, 2025
@oliverklee
[TASK] Remove OutputFormat::get()
2d3b691 
We now have beautiful, cleanly-typed getters to use instead.

Part of #1103
@oliverklee oliverklee mentioned this issue Mar 7, 2025
Merged
JakeQZ pushed a commit that referenced this issue Mar 7, 2025
@oliverklee
[CLEANUP] Use the explicit OutputFormat setters in the tests (#1106)
9e087c5 
The `set()` method will be removed soon.

Also unify the tests a bit.

Part of #1103
JakeQZ added a commit that referenced this issue Mar 7, 2025
@oliverklee @JakeQZ
[TASK] Deprecate OutputFormat::get() and ::set() (#1107)
efad65a 
Part of #1103

Co-authored-by: JakeQZ <[email protected]>
JakeQZ pushed a commit that referenced this issue Mar 7, 2025
@oliverklee
[TASK] Remove OutputFormat::get() (#1108)
b7367c8 
We now have beautiful, cleanly-typed getters to use instead.

Part of #1103
oliverklee added a commit that referenced this issue Mar 7, 2025
@oliverklee
[TASK ] Remove OutputFormat::set()
acc394e 
Part of #1103
Closes #1103
@oliverklee oliverklee mentioned this issue Mar 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging a pull request may close this issue.

[TASK ] Remove OutputFormat::set() MyIntervals/PHP-CSS-Parser
1 participant
@oliverklee