Skip to content

[TASK ] Remove OutputFormat::set() #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

[TASK ] Remove OutputFormat::set() #1110

merged 1 commit into from
Mar 7, 2025

Conversation

oliverklee
Copy link
Collaborator

Part of #1103
Closes #1103

@oliverklee oliverklee requested a review from JakeQZ March 7, 2025 16:56
@oliverklee oliverklee self-assigned this Mar 7, 2025
JakeQZ
JakeQZ approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There weren't too many worms in the can.

We can now avoid Hungarian notation for the properties.

@oliverklee oliverklee enabled auto-merge (squash) March 7, 2025 17:03
@oliverklee oliverklee merged commit a031106 into main Mar 7, 2025
21 checks passed
@oliverklee oliverklee deleted the task/drop-set branch March 7, 2025 17:03
@coveralls
Copy link

Coverage Status

coverage: 55.567% (+0.5%) from 55.037%
when pulling acc394e on task/drop-set
into fff77eb on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.

Get rid of OutputFormat::get() and ::set()
3 participants
@oliverklee @coveralls @JakeQZ