[CLEANUP] Use the explicit OutputFormat setters in the tests
#1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
task/avoid-set-get
branch
from
0fcad40 to
9eb4feb
Compare
JakeQZ
requested changes
Mar 7, 2025
| @@ -280,6 +310,8 @@ public function ignoreExceptionsOff(): void | |||
| { | |||
| $this->expectException(OutputException::class); | |||
|
|
|||
| $outputFormat = OutputFormat::create()->setIgnoreExceptions(false); | |||
There was a problem hiding this comment.
This test uses two separate OutputFormats.
There was a problem hiding this comment.
I've now changed it to use the same instance (as it doesn't seem relevant to me to use two instances with identical settings).
There was a problem hiding this comment.
it doesn't seem relevant to me to use two instances with identical settings
Me neither - given that it's just testing that an exception is thrown when attempting to render a declaration block without a selector.
The `set()` method will be removed soon. Also unify the tests a bit. Part of #1103
oliverklee
force-pushed
the
task/avoid-set-get
branch
from
9eb4feb to
504e142
Compare
JakeQZ
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
set()method will be removed soon.Also unify the tests a bit.
Part of #1103