-
Notifications
You must be signed in to change notification settings - Fork 144
[CLEANUP] Use the explicit OutputFormat
setters in the tests
#1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0fcad40
to
9eb4feb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One test uses two separate OutputFormat
s.
@@ -280,6 +310,8 @@ public function ignoreExceptionsOff(): void | |||
{ | |||
$this->expectException(OutputException::class); | |||
|
|||
$outputFormat = OutputFormat::create()->setIgnoreExceptions(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test uses two separate OutputFormat
s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now changed it to use the same instance (as it doesn't seem relevant to me to use two instances with identical settings).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't seem relevant to me to use two instances with identical settings
Me neither - given that it's just testing that an exception is thrown when attempting to render a declaration block without a selector.
The `set()` method will be removed soon. Also unify the tests a bit. Part of #1103
9eb4feb
to
504e142
Compare
The
set()
method will be removed soon.Also unify the tests a bit.
Part of #1103