[BUGFIX] Include comments for all rules in declaration block #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeQZ
added this to the 8.8.0: Deprecate and replace some APIs, and a few fixes milestone
This is the v8.x backport of #1169. - `Rule::parse()` will no longer consume anything after the semicolon terminating the rule - it does not belong to that rule; - The whitespace and comments before a rule will be processed by `RuleSet::parseRuleSet()` and passed as a parameter to `Rule::parse()` - - This is only required while 'strict mode' parsing is an option, to avoid having an exception thrown during normal operation (i.e. when `Rule::parse()` encounters normal `}` as opposed to some other junk, which is not distinguished). Fixes #173. See also #663, #672, #741.
JakeQZ
force-pushed
the
bugfix/8.x/ruleset-comments
branch
from
6f1840d to
915acd5
Compare
oliverklee
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the v8.x backport of #1169.
Rule::parse()will no longer consume anything after the semicolon terminating the rule - it does not belong to that rule;RuleSet::parseRuleSet()and passed as a parameter toRule::parse()-Rule::parse()encounters normal}as opposed to some other junk, which is not distinguished).Fixes #173.
See also #663, #672, #741.