Skip to content

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Mar 16, 2025

This is the v8.x backport of #1169.

  • Rule::parse() will no longer consume anything after the semicolon terminating the rule - it does not belong to that rule;
  • The whitespace and comments before a rule will be processed by RuleSet::parseRuleSet() and passed as a parameter to Rule::parse() -
    • This is only required while 'strict mode' parsing is an option, to avoid having an exception thrown during normal operation (i.e. when Rule::parse() encounters normal } as opposed to some other junk, which is not distinguished).

Fixes #173.
See also #663, #672, #741.

This is the v8.x backport of #1169.

- `Rule::parse()` will no longer consume anything after the semicolon
  terminating the rule - it does not belong to that rule;
- The whitespace and comments before a rule will be processed by
  `RuleSet::parseRuleSet()` and passed as a parameter to `Rule::parse()` -
  - This is only required while 'strict mode' parsing is an option,
    to avoid having an exception thrown during normal operation
    (i.e. when `Rule::parse()` encounters normal `}`
    as opposed to some other junk, which is not distinguished).

Fixes #173.
See also #663, #672, #741.
@oliverklee oliverklee merged commit 4870566 into v8.x Mar 17, 2025
22 checks passed
@oliverklee oliverklee deleted the bugfix/8.x/ruleset-comments branch March 17, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants