[BUGFIX] Fix comment parsing to support multiple comments #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by only consuming real whitespace without comments after a rule. Fixes #173 Signed-off-by: Daniel Ziegenberg <[email protected]>
oliverklee
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
This was referenced Aug 25, 2024
JakeQZ
pushed a commit
that referenced
this pull request
Oct 24, 2024
JakeQZ
pushed a commit
that referenced
this pull request
Oct 24, 2024
JakeQZ
added a commit
that referenced
this pull request
Mar 15, 2025
- `Rule::parse()` will no longer consume anything after the semicolon
terminating the rule - it does not belong to that rule;
- The whitespace and comments before a rule will be processed by
`RuleSet::parseRuleSet()` and passed as a parameter to `Rule::parse()` -
- This is only required while 'strict mode' parsing is an option,
to avoid having an exception thrown during normal operation
(i.e. when `Rule::parse()` encounters normal `}`
as opposed to some other junk, which is not distinguished).
Fixes #173.
See also #672, #741.
JakeQZ
added a commit
that referenced
this pull request
Mar 15, 2025
- `Rule::parse()` will no longer consume anything after the semicolon
terminating the rule - it does not belong to that rule;
- The whitespace and comments before a rule will be processed by
`RuleSet::parseRuleSet()` and passed as a parameter to `Rule::parse()` -
- This is only required while 'strict mode' parsing is an option,
to avoid having an exception thrown during normal operation
(i.e. when `Rule::parse()` encounters normal `}`
as opposed to some other junk, which is not distinguished).
Fixes #173.
See also #672, #741.
oliverklee
pushed a commit
that referenced
this pull request
Mar 16, 2025
- `Rule::parse()` will no longer consume anything after the semicolon
terminating the rule - it does not belong to that rule;
- The whitespace and comments before a rule will be processed by
`RuleSet::parseRuleSet()` and passed as a parameter to `Rule::parse()` -
- This is only required while 'strict mode' parsing is an option,
to avoid having an exception thrown during normal operation
(i.e. when `Rule::parse()` encounters normal `}`
as opposed to some other junk, which is not distinguished).
Fixes #173.
See also #672, #741.
JakeQZ
added a commit
that referenced
this pull request
Mar 16, 2025
This is the v8.x backport of #1169. - `Rule::parse()` will no longer consume anything after the semicolon terminating the rule - it does not belong to that rule; - The whitespace and comments before a rule will be processed by `RuleSet::parseRuleSet()` and passed as a parameter to `Rule::parse()` - - This is only required while 'strict mode' parsing is an option, to avoid having an exception thrown during normal operation (i.e. when `Rule::parse()` encounters normal `}` as opposed to some other junk, which is not distinguished). Fixes #173. See also #663, #672, #741.
JakeQZ
added a commit
that referenced
this pull request
Mar 16, 2025
This is the v8.x backport of #1169. - `Rule::parse()` will no longer consume anything after the semicolon terminating the rule - it does not belong to that rule; - The whitespace and comments before a rule will be processed by `RuleSet::parseRuleSet()` and passed as a parameter to `Rule::parse()` - - This is only required while 'strict mode' parsing is an option, to avoid having an exception thrown during normal operation (i.e. when `Rule::parse()` encounters normal `}` as opposed to some other junk, which is not distinguished). Fixes #173. See also #663, #672, #741.
oliverklee
pushed a commit
that referenced
this pull request
Mar 17, 2025
This is the v8.x backport of #1169. - `Rule::parse()` will no longer consume anything after the semicolon terminating the rule - it does not belong to that rule; - The whitespace and comments before a rule will be processed by `RuleSet::parseRuleSet()` and passed as a parameter to `Rule::parse()` - - This is only required while 'strict mode' parsing is an option, to avoid having an exception thrown during normal operation (i.e. when `Rule::parse()` encounters normal `}` as opposed to some other junk, which is not distinguished). Fixes #173. See also #663, #672, #741.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by only consuming real whitespace without comments after a rule.
Fixes #173