Skip to content

[TASK] Remove getColNo() #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

[TASK] Remove getColNo() #1287

merged 1 commit into from
Jun 24, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Jun 24, 2025

Note that the removed tests are in UnitDeprecated. Equivalent tests already exist for the replacement getColumnNumber().

Part of #974

@JakeQZ JakeQZ requested a review from oliverklee June 24, 2025 21:10
@JakeQZ JakeQZ self-assigned this Jun 24, 2025
@JakeQZ JakeQZ added the removal A method, property, or some functionality has been removed. label Jun 24, 2025
@coveralls
Copy link

coveralls commented Jun 24, 2025

Coverage Status

coverage: 57.953% (-0.05%) from 57.999%
when pulling c841819 on remove/getcolno
into 1dec641 on main.

Note that the removed tests are in `UnitDeprecated`.
Equivalent tests already exist for the replacement `getColumnNumber()`.

Part of #974
@JakeQZ JakeQZ force-pushed the remove/getcolno branch from 4d0c2c5 to c841819 Compare June 24, 2025 21:15
@oliverklee oliverklee merged commit 710dab9 into main Jun 24, 2025
21 checks passed
@oliverklee oliverklee deleted the remove/getcolno branch June 24, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removal A method, property, or some functionality has been removed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants