[TASK] Use native type declarations for $lineNumber
#1134
Conversation
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
There was a problem hiding this comment.
There's a duplicated parameter name in one DocBlock.
I made some suggestions, perhaps for a separate PR, where I think $lineNumber is necessarily always at least 1. Though given that this PR already includes one change to int<1, max>, perhaps those should be included here. I'll leave it to your discretion...
| @@ -20,9 +20,9 @@ class Parser | |||
|
|
|||
| /** | |||
| * @param string $text the complete CSS as text (i.e., usually the contents of a CSS file) | |||
| * @param int<0, max> $lineNumber the line number (starting from 1, not from 0) | |||
| * @param int<1, max> $lineNumber the line number (starting from 1, not from 0) | |||
src/Parsing/ParserState.php
Outdated
| @@ -45,15 +45,15 @@ class ParserState | |||
| private $charset; | |||
|
|
|||
| /** | |||
| * @var int | |||
| * @var int<0, max> $lineNumber | |||
There was a problem hiding this comment.
I wonder if $lineNumber can ever be 0 here. 0 is used in the various objects to indicate that no line number is available (e.g. for something added to the Document after parsing), but I think ParserState always has a valid line number which is greater than 0. Maybe beyond the scope of this PR.
src/Parsing/ParserState.php
Outdated
| @@ -45,15 +45,15 @@ class ParserState | |||
| private $charset; | |||
|
|
|||
| /** | |||
| * @var int | |||
| * @var int<0, max> $lineNumber | |||
| */ | |||
| private $lineNumber; | |||
|
|
|||
| /** | |||
| * @param string $text the complete CSS as text (i.e., usually the contents of a CSS file) | |||
| * @param int<0, max> $lineNumber | |||
There was a problem hiding this comment.
Ditto here. The default parameter value is 1, which sort-of implies it will always be at least 1.
Co-authored-by: JakeQZ <[email protected]>
Part of #811