[TASK] Set line number to null by default
#1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeQZ
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
added
the
removal
JakeQZ
force-pushed
the
task/linenumber-null
branch
from
3007083 to
83f5e82
Compare
No longer allow or support `0` as a default line or column number. Part of #974
JakeQZ
force-pushed
the
task/linenumber-null
branch
from
83f5e82 to
b4ed61c
Compare
oliverklee
approved these changes
Jun 26, 2025
JakeQZ
added a commit
that referenced
this pull request
Jun 26, 2025
The bug was introduced by #1288, so has not been included in any release; thus a changelog entry is not justified.
oliverklee
pushed a commit
that referenced
this pull request
Jun 26, 2025
The bug was introduced by #1288, so has not been included in any release; thus a changelog entry is not justified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer allow or support
0as a default line or column number.Part of #974