bump nemo and remove manual tensorstore install#619
Merged
pstjohn merged 1 commit intoNVIDIA:mainfrom Jan 21, 2025
Merged
Conversation
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
pstjohn
requested review from
dorotat-nv,
jstjohn,
malcolmgreaves,
ohadmo and
trvachov
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 116 116
Lines 6961 6961
=======================================
Hits 6030 6030
Misses 931 931 ☔ View full report in Codecov by Sentry. |
jstjohn
approved these changes
Jan 21, 2025
dorotat-nv
approved these changes
Jan 21, 2025
polinabinder1
pushed a commit
that referenced
this pull request
Jan 22, 2025
With NVIDIA-NeMo/NeMo#11777, NVIDIA-NeMo/NeMo#11858, and NVIDIA/Megatron-LM@a26b93d, we're now ready to remove the manual tensorstore install from bionemo. Signed-off-by: Peter St. John <pstjohn@nvidia.com> Signed-off-by: Polina Binder <pbinder@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With NVIDIA-NeMo/NeMo#11777, NVIDIA-NeMo/NeMo#11858, and NVIDIA/Megatron-LM@a26b93d, we're now ready to remove the manual tensorstore install from bionemo.