perf: Jackson Codec allocation improvements#1609
Merged
fvallenilla merged 2 commits intoNetflix:2.xfrom Jan 16, 2026
Merged
Conversation
jasonk000
changed the title
fvallenilla
approved these changes
Jan 16, 2026
| CharBuffer otherBuffer = (CharBuffer) other; | ||
| if (otherBuffer.length() == length && otherBuffer.variant() == variant) { | ||
| OfInt otherText = otherBuffer.chars(); | ||
| for (int i = offset; i < offset + length; i++) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes, (1) the getText toUpperCase call gets a slight transform to avoid a lambda capture. More significantly, we (2) introduce a mutable ArrayCharBuffer and StringCharBuffer to avoid repeated allocations of the buffer themselves. The buffers are only used during intermediate calls, and, the class is clearly marked as not-thread-safe and is attached to independent ObjectReader.