Skip to content

perf: Jackson Codec allocation improvements #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fvallenilla merged 2 commits into from
Jan 16, 2026
+424 −202
Merged

perf: Jackson Codec allocation improvements #1609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4903007
perf: Reduce allocations in DeserializerStringCache by reusing parser…
jasonk000 Jan 7, 2026
4588001
perf: Avoid lambda capture in InstanceInfoDeserializer toUpperCase ex…
jasonk000 Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions eureka-client/src/main/java/com/netflix/discovery/converters/EurekaJacksonCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,15 @@ protected void autoMarshalEligible(Object o, JsonGenerator jgen) {
public static class InstanceInfoDeserializer extends JsonDeserializer<InstanceInfo> {
private static char[] BUF_AT_CLASS = "@class".toCharArray();

/** Extract uppercase from current JsonParser cursor. Avoids lambda capture. */
private static String toUpperCase(JsonParser jp) {
try {
return jp.getText().toUpperCase();
} catch (IOException e) {
throw new RuntimeJsonMappingException(e.getMessage());
}
}

enum InstanceInfoField {
HOSTNAME(ELEM_HOST),
INSTANCE_ID(ELEM_INSTANCE_ID),
Expand Down Expand Up @@ -515,14 +524,7 @@ public InstanceInfo deserialize(JsonParser jp, DeserializationContext context) t
break;
case APP:
builder.setAppNameForDeser(
intern.apply(jp, CacheScope.APPLICATION_SCOPE,
()->{
try {
return jp.getText().toUpperCase();
} catch (IOException e) {
throw new RuntimeJsonMappingException(e.getMessage());
}
}));
intern.apply(jp, CacheScope.APPLICATION_SCOPE, InstanceInfoDeserializer::toUpperCase));
break;
case IP:
builder.setIPAddr(intern.apply(jp));
Expand Down Expand Up @@ -590,14 +592,8 @@ public InstanceInfo deserialize(JsonParser jp, DeserializationContext context) t
builder.setHealthCheckUrlsForDeser(null, intern.apply(jp.getText()));
break;
case APPGROUPNAME:
builder.setAppGroupNameForDeser(intern.apply(jp, CacheScope.GLOBAL_SCOPE,
()->{
try {
return jp.getText().toUpperCase();
} catch (IOException e) {
throw new RuntimeJsonMappingException(e.getMessage());
}
}));
builder.setAppGroupNameForDeser(
intern.apply(jp, CacheScope.GLOBAL_SCOPE, InstanceInfoDeserializer::toUpperCase));
break;
case HOMEPAGEURL:
builder.setHomePageUrlForDeser(intern.apply(jp.getText()));
Expand Down
Loading