Add nomination issue template

[jtojnar]

A new, more organized way to nominate Nixpkgs committers.

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-templates

[jtojnar]

Will want to set up CI to notify NixOS/nixpkgs#321665

[wolfgangwalther]

IIRC, there were some commands that people are running nowadays to get the respective links to "reviewed PRs", "authored PRs" etc.

Maybe provide these commands in the PR template as a base? Or would these be filled by CI somehow?

[wolfgangwalther]

bug report is wrong, I think.

[SigmaSquadron]

I do apologise if we shouldn't review this yet, as it's a draft, but there are some things I learned while making the YAML forms for Nixpkgs that may be helpful here too.

[SigmaSquadron]

Suggested change

	title: "[Nomination]: "
	title: "[Nomination]: NAME"

We have placeholders like PACKAGENAME in Nixpkgs, and they usually work like 95% of the time. Since the only people being nominated here are supposed to be reasonably proficient with Nixpkgs' workflow, I think everyone will manage to replace it.

[SigmaSquadron]

This wording seems to imply that self-nominations will no longer be allowed? Will there be a separate issue template for self-nominations? Are they outright banned?

[khaneliman]

I don't get that from the wording, just says you're nominating a singular user.

[SigmaSquadron]

I would highly recommend adding a markdown item as the first form component that explains in more detail what this is all for. See the Nixpkgs bug report template for reference.

[SigmaSquadron]

Suggested change

	label: GitHub user name
	placeholder: octocat
	label: GitHub Username
	description: The GitHub username currently used by the committer nominee.

In Nixpkgs, we removed placeholders in order to reduce the overall information density. I would recommend doing the same here and using descriptions instead.

NixOS/nixpkgs#368656 (review)

[SigmaSquadron]

I feel like we can split this up into a few more questions. Most nominations in the old issue follow mostly the same format (sometimes the first and second paragraph are flipped):

1. First paragraph introduces the person and shows something notable that they have done. This is usually a large NixOS module or something equally impactful.
2. Second paragraph usually mentions how long the person has been contributing for, and what their merged/reviewed PR stats are. (unless the stats are at the bottom of the post)
3. Third paragraph is usually the actual reason why the person should be a committer.

I think splitting this question appropriately will allow the delegation team to more efficiently review nominations, as they would have a very similar format to each other.

[SigmaSquadron]

This feels a bit redundant since the Discourse link is also available from the documentation below.

[khaneliman]

Suggested change

	description: Why I are you nominating this person? Please include links to their relevant PR and reviewing activity.
	description: Why are you nominating this person? Please include links to their relevant PR and reviewing activity.

[philiptaron]

NixOS/nixpkgs#368656 is the PR (significant!) that @SigmaSquadron authored to successfully convert over Nixpkgs issues to templates. His feedback is really informed and wise!

I want to say a few things with this PR:

1. It's excellent that we're going to use this repository to track things. Way to go @NixOS/commit-bit-delegation team.
2. Making an issue per person nominated is obviously the right thing to do.
3. This is the place to outline the norms of what it means to be a nixpkgs contributor.
4. This is also the place to welcome people to that next echelon of responsibility.
5. This is also the place to coach people forward through time til they hit the mark!
6. I can't wait for this to get merged so that we can direct folks to it. It's going to be a massive upgrade on the drama-ridden main issue in Nixpkgs.