Skip to content

Add nomination issue template #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add nomination issue template #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26fff25
Add issue template config
jtojnar Aug 13, 2025
3c50152
Add nomination issue template
jtojnar Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/ISSUE_TEMPLATE/01_nomination.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: Committer Nomination
description: Nominate a user for Nixpkgs commit access.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording seems to imply that self-nominations will no longer be allowed? Will there be a separate issue template for self-nominations? Are they outright banned?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get that from the wording, just says you're nominating a singular user.

title: "[Nomination]: "
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: "[Nomination]: "
title: "[Nomination]: NAME"

We have placeholders like PACKAGENAME in Nixpkgs, and they usually work like 95% of the time. Since the only people being nominated here are supposed to be reasonably proficient with Nixpkgs' workflow, I think everyone will manage to replace it.

labels: ["nomination"]
assignees:
- @NixOS/commit-bit-delegation
body:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would highly recommend adding a markdown item as the first form component that explains in more detail what this is all for. See the Nixpkgs bug report template for reference.

- type: input
id: user
attributes:
label: GitHub user name
placeholder: octocat
Comment on lines +11 to +12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label: GitHub user name
placeholder: octocat
label: GitHub Username
description: The GitHub username currently used by the committer nominee.

In Nixpkgs, we removed placeholders in order to reduce the overall information density. I would recommend doing the same here and using descriptions instead.

NixOS/nixpkgs#368656 (review)

validations:
required: true
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this bug report!
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug report is wrong, I think.

- type: textarea
id: reason
attributes:
label: Reason
description: Why I are you nominating this person? Please include links to their relevant PR and reviewing activity.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Why I are you nominating this person? Please include links to their relevant PR and reviewing activity.
description: Why are you nominating this person? Please include links to their relevant PR and reviewing activity.

validations:
required: true
Comment on lines +19 to +25
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we can split this up into a few more questions. Most nominations in the old issue follow mostly the same format (sometimes the first and second paragraph are flipped):

  1. First paragraph introduces the person and shows something notable that they have done. This is usually a large NixOS module or something equally impactful.
  2. Second paragraph usually mentions how long the person has been contributing for, and what their merged/reviewed PR stats are. (unless the stats are at the bottom of the post)
  3. Third paragraph is usually the actual reason why the person should be a committer.

I think splitting this question appropriately will allow the delegation team to more efficiently review nominations, as they would have a very similar format to each other.

7 changes: 7 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
contact_links:
- name: Contact the Committer Delegation Team via group message on Discourse
url: https://discourse.nixos.org/g/nixpkgs-nominations
about: For private inquiries and suggestions.
Comment on lines +2 to +4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit redundant since the Discourse link is also available from the documentation below.

- name: Contact the individual Committer Delegation Team members
url: https://github.com/NixOS/org/blob/main/doc/nixpkgs-committers.md#team
about: For private inquiries and suggestions.