fix(gateway): preserve newest thread participation entries#13639
Closed
hharry11 wants to merge 1 commit into
Closed
fix(gateway): preserve newest thread participation entries#13639hharry11 wants to merge 1 commit into
hharry11 wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThreadParticipationTrackerinstead of storing participated threads in an unordered set.Why
Discord/Matrix thread participation state is capped, but converting persisted JSON to a set made eviction order nondeterministic. A newly participated thread could be dropped from the saved state, causing follow-up messages after gateway restart to require a mention again.
Test
uv run --extra dev python -m pytest tests/gateway/test_discord_thread_persistence.py -q -n 4