fix(gateway): deterministic thread eviction preserves newest entries (salvage #13639)#20285
Merged
Conversation
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages @hharry11's PR #13639 onto current main.
What it does
ThreadParticipationTrackerstored threads in asetand relied onlist(set)ordering for capacity eviction. Since Python sets are unordered, a newlymark()-ed thread could be evicted by the next capacity trim while older entries survived — non-deterministic, and specifically bad on Discord where a recently-joined thread might disappear from the participation cache.Switch to a
dict[str, None]which preserves insertion order; the newestmark()-ed thread is always at the end and survives[-max_tracked:]trimming.Changes
gateway/platforms/helpers.py—_threadsis now a dict keyed by thread id._loadreturns an ordered list. Save still uses main'satomic_json_write.tests/gateway/test_discord_thread_persistence.py— assertion on evicted-set ordering + new test for the newest-survives case.scripts/release.py— AUTHOR_MAP entry for hharry11.Validation
tests/gateway/test_discord_thread_persistence.py— 8 passed locally.Closes #13639 via salvage.