Skip to content

[17.0][MIG] account_statement_base: Migration to 17.0#614

Merged
OCA-git-bot merged 23 commits into
OCA:17.0from
adhoc-dev:17.0-mig-account_statement_base
Feb 4, 2024
Merged

[17.0][MIG] account_statement_base: Migration to 17.0#614
OCA-git-bot merged 23 commits into
OCA:17.0from
adhoc-dev:17.0-mig-account_statement_base

Conversation

@rov-adhoc
Copy link
Copy Markdown
Contributor

@rov-adhoc rov-adhoc commented Dec 15, 2023

No description provided.

alexis-via and others added 23 commits December 15, 2023 10:47
@alexis-via @rov-adhoc
[ADD] module account_statement_base
bb29780 
This module contains the views of account.bank.statement.line, which
have been removed from the account module in Odoo v16
@rov-adhoc
[UPD] Update account_statement_base.pot
fdbfa75
@OCA-git-bot @rov-adhoc
[UPD] README.rst
fe10290
@OCA-git-bot @rov-adhoc
[ADD] icon.png
8287615
@alexis-via @rov-adhoc
account_statement_base: change licence to LGPL
68eed89 
The module account_statement_base will be used by the modules from
OCA/bank-statement-import which are LGPL (because they initially
came from Odoo official addons), so it cannot be AGPL.
@OCA-git-bot @rov-adhoc
[UPD] README.rst
4f05534
@OCA-git-bot @rov-adhoc
account_statement_base 16.0.1.1.0
81d60e6
@alexis-via @rov-adhoc
account_statement_base: add development_status in manifest
849c321
@OCA-git-bot @rov-adhoc
[UPD] README.rst
6494a9c
@OCA-git-bot @rov-adhoc
account_statement_base 16.0.1.2.0
b238b78
@etobella @rov-adhoc
[IMP] account_reconcile_oca: Finish creation of module
2c4cb1b 
* refactoring JS in order to add logic
* Improve views
* Minor fixes in Odoo code in order to fix all possible options
@rov-adhoc
[UPD] Update account_statement_base.pot
fddc3f9
@NL66278 @rov-adhoc
[IMP] account_statement_base: add form to statement view_mode
70bae87
@OCA-git-bot @rov-adhoc
account_statement_base 16.0.1.3.0
4bd38b3
@adrianojprado @rov-adhoc
Added translation using Weblate (Portuguese (Brazil))
a59bf25
@adrianojprado @rov-adhoc
Translated using Weblate (Portuguese (Brazil))
34855a7 
Currently translated at 100.0% (12 of 12 strings)

Translation: account-reconcile-16.0/account-reconcile-16.0-account_statement_base
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_statement_base/pt_BR/
@Ivorra78 @rov-adhoc
Added translation using Weblate (Spanish)
0613d76
@Ivorra78 @rov-adhoc
Translated using Weblate (Spanish)
0eab62c 
Currently translated at 100.0% (12 of 12 strings)

Translation: account-reconcile-16.0/account-reconcile-16.0-account_statement_base
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_statement_base/es/
@remi-filament @rov-adhoc
Added translation using Weblate (French)
5bfd130
@remi-filament @rov-adhoc
Translated using Weblate (French)
99212ff 
Currently translated at 100.0% (12 of 12 strings)

Translation: account-reconcile-16.0/account-reconcile-16.0-account_statement_base
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_statement_base/fr/
@OCA-git-bot @rov-adhoc
[UPD] README.rst
f9e4e8f
@rov-adhoc
[IMP] account_statement_base: pre-commit auto fixes
0c7a607
@rov-adhoc
[MIG] account_statement_base: Migration to 17.0
b28dc0e
@rov-adhoc rov-adhoc changed the title 17.0 mig account statement base [17.0][MIG] account statement base: Migration to 17.0 Dec 15, 2023
@rov-adhoc rov-adhoc mentioned this pull request Dec 15, 2023
Merged
@pedrobaeza pedrobaeza changed the title [17.0][MIG] account statement base: Migration to 17.0 [17.0][MIG] account_statement_base: Migration to 17.0 Dec 15, 2023
@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Dec 15, 2023

Thanks for the PR title renaming. You just have missed the underscores on the module name. I have just put them.

/ocabot migration account_statement_base

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 15, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 15, 2023
Open
8 tasks
@rov-adhoc
Copy link
Copy Markdown
Contributor Author

rov-adhoc commented Dec 19, 2023

@pedrobaeza Hi Pedro! I would like to ask you if there is something missing in this PR in order to be merge it. Thanks in advance! Best regards!

@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Dec 19, 2023

Reviews: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

You can review other PRs, and ask in exchange they review yours.

@StefanRijnhart
Copy link
Copy Markdown
Member

StefanRijnhart commented Feb 2, 2024

Can you check the warning that Odoo emits on installation of the module?

2023-12-15 16:14:37,845 230 INFO odoo odoo.modules.loading: Loading module account_statement_base (40/43) 
2023-12-15 16:14:37,966 230 WARNING odoo py.warnings: /opt/odoo/odoo/addons/base/models/ir_module.py:170: DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, account_statement_base can just have a UTF8 description with not need for a declaration.

@StefanRijnhart
Copy link
Copy Markdown
Member

StefanRijnhart commented Feb 2, 2024

Oh, fixed here I see. OCA/maintainer-tools#595

norlinhenrik
norlinhenrik approved these changes Feb 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@norlinhenrik norlinhenrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I installed it and opened a statement and one of its lines in form view.)

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Feb 3, 2024

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart
Copy link
Copy Markdown
Member

StefanRijnhart commented Feb 4, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Feb 4, 2024

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-614-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit db2ebe2 into OCA:17.0 Feb 4, 2024
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Feb 4, 2024

Congratulations, your PR was merged at c24a979. Thanks a lot for contributing to OCA. ❤️

@hbrunn hbrunn mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

+1 more reviewer

@norlinhenrik norlinhenrik norlinhenrik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.