Skip to content

[FIX] report_substitute: avoid write over the mail template #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[FIX] report_substitute: avoid write over the mail template #1001

wants to merge 1 commit into from

Conversation

augusto-weiss
Copy link

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @sbejaoui,
some modules you are maintaining are being modified, check this out!

@augusto-weiss
Copy link
Author

FW of #994

@augusto-weiss
Copy link
Author

@sbejaoui @jjscarafia @HviorForgeFlow Hello guys, could you review this fordwar-port of #994 ? Thanks a lot

@amkarthik amkarthik mentioned this pull request Jul 14, 2025
Open
@zaoral
Copy link

zaoral commented Jul 14, 2025

Thank you for the manual FW @augusto-weiss !

I confirm this is needed in the 17 and 18 versions, and it is an important fix, because it will avoid a concurrency problem. For example, when validating and auto-sending invoices.

Best Regards

@HviorForgeFlow
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1001-by-HviorForgeFlow-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 14, 2025
@OCA-git-bot
Merge PR #1001 into 17.0
33be2d6 
Signed-off-by HviorForgeFlow
@OCA-git-bot
Copy link
Contributor

@HviorForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1001-by-HviorForgeFlow-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@HviorForgeFlow
Copy link
Member

@pedrobaeza could you take a quick look here? A solution does not come me up. It looks like an error with a cryptography dependency but, in the past the related module was merge with any problem.

#991

@pedrobaeza pedrobaeza added this to the 17.0 milestone Jul 16, 2025
@pedrobaeza
Copy link
Member

Try to pin the library version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaoral zaoral zaoral approved these changes

@amkarthik amkarthik amkarthik approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@augusto-weiss @OCA-git-bot @zaoral @HviorForgeFlow @pedrobaeza @amkarthik