[18.0] MIG report_substitute #1033
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addon give the possibility to substitute a report action by another based on some criteria.
Currently translated at 100.0% (21 of 21 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_substitute Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_substitute/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-17.0/reporting-engine-17.0-report_substitute Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-report_substitute/
Currently translated at 100.0% (19 of 19 strings) Translation: reporting-engine-17.0/reporting-engine-17.0-report_substitute Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-report_substitute/it/
samirGuesmi
force-pushed
the
18.0-mig-report_substitute
branch
from
860ec85 to
2c2afe7
Compare
sbejaoui
force-pushed
the
18.0-mig-report_substitute
branch
from
bb57fb1 to
bb0c307
Compare
sbejaoui
approved these changes
Jun 13, 2025
amkarthik
reviewed
Jun 16, 2025
report_substitute/__manifest__.py
Outdated
| "demo": ["demo/action_report.xml"], | ||
| "assets": { | ||
| "web.assets_backend": [ | ||
| "report_substitute/static/src/js/action_manager.js", |
There was a problem hiding this comment.
Can you please check the file name?
There was a problem hiding this comment.
can you update your review please
…ect report handler When the report type differs between the original report and the substitution, the substitution_handler must return the handler corresponding to the substitution report type Failing to do so may cause issues, as the report action would be executed using a handler from a different report type, leading to unexpected behavior or errors
sbejaoui
force-pushed
the
18.0-mig-report_substitute
branch
from
bb0c307 to
07c5ccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on PR#948
This PR fixes the report rendering logic to properly handle substitution reports that use a format other than qweb-pdf. If the substituted report has a different report type, the system will now fall back to _render() instead of _render_qweb_pdf(), ensuring correct rendering and avoiding format-related errors.