[18.0][MIG] fs_base_multi_image #447

rousseldenis · 2025-02-20T09:44:06Z

Depends on:

…product

Currently translated at 100.0% (25 of 25 strings) Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/es/

Currently translated at 100.0% (25 of 25 strings) Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/it/

…th same label for image/image_1920 and image_medium/image_128 for product.template and product.product

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/

Currently translated at 100.0% (26 of 26 strings) Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/it/

…ger the inverse method, which results in a ValueError

…selection

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/

Currently translated at 100.0% (32 of 32 strings) Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/es/

Currently translated at 100.0% (32 of 32 strings) Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/it/

Currently translated at 62.5% (20 of 32 strings) Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/fr/

Currently translated at 75.0% (24 of 32 strings) Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/fr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-17.0/storage-17.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_base_multi_image/

Currently translated at 100.0% (33 of 33 strings) Translation: storage-17.0/storage-17.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_base_multi_image/it/

…ORM explicitely

lmignon · 2025-02-24T08:41:48Z

/ocabot migration fs_base_multi_image

lmignon

LGTM (Code review + diff with 16.0 and functional via #449)

youring

To make kanban image draggable, thus allow easily change the main image

youring · 2025-02-26T05:26:09Z

fs_base_multi_image/views/fs_image_relation_mixin.xml

+        <field name="arch" type="xml">
+            <kanban>
+                <field name="image" />
+                <field name="sequence" />


Suggested change

<field name="sequence" />

<field name="sequence" widget="handle" />

youring · 2025-02-26T12:59:58Z

fs_base_multi_image/views/fs_image.xml

+    <record model="ir.actions.act_window" id="fs_image_act_window">
+        <field name="name">Fs Image</field>
+        <field name="res_model">fs.image</field>
+        <field name="view_mode">tree,form</field>


Suggested change

<field name="view_mode">tree,form</field>

<field name="view_mode">list,form</field>

xaviedoanhduy · 2025-04-21T04:28:51Z

fs_base_multi_image/tests/test_base_multi_image.py

+from odoo.addons.base.tests.common import BaseCommon
+from odoo.addons.fs_image.fields import FSImageValue
+
+


Suggested change

@odoo.tests.tagged("post_install", "-at_install")

Hi @rousseldenis, can you add the following code? Using the BaseCommon class and not moving it to post_install could result in tests of modules that depend on this PR failing like this: https://github.com/xaviedoanhduy/storage/actions/runs/14566155548/job/40855697358

kobros-tech

there is a conflict, I would solve it if you are busy and don't mind?

lmignon · 2025-08-19T08:59:11Z

ping @rousseldenis

lmignon and others added 30 commits February 19, 2025 16:43

[ADD] fs_product_multi_image: a drop-in replacement of storage_image_…

cdf15c2

…product

[UPD] Update fs_base_multi_image.pot

3864c36

[BOT] post-merge updates

b04fc82

Added translation using Weblate (Spanish)

e42c584

Translated using Weblate (Spanish)

550603d

Currently translated at 100.0% (25 of 25 strings) Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/es/

Added translation using Weblate (Italian)

ccb2d91

Translated using Weblate (Italian)

46dfa52

Currently translated at 100.0% (25 of 25 strings) Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/it/

[FIX] updated image and image_medium label to prevent odoo warning wi…

32d77de

…th same label for image/image_1920 and image_medium/image_128 for product.template and product.product

[UPD] Update fs_base_multi_image.pot

a2919c3

[BOT] post-merge updates

508225f

Update translation files

9314f07

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/

Translated using Weblate (Italian)

be55682

Currently translated at 100.0% (26 of 26 strings) Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/it/

[FIX] Creating new relation records in the UI with link_existing trig…

341ac74

…ger the inverse method, which results in a ValueError

[ADD] new widget to allow image upload through drag and drop or file …

efeb4f0

…selection

[ADD] allow user to select where he want to store the image

8da9165

[IMP] block the UI during the upload

af0af03

[UPD] Update fs_base_multi_image.pot

f220f97

[BOT] post-merge updates

5ebe46c

Update translation files

53120f6

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/

Translated using Weblate (Spanish)

89a3e2f

Currently translated at 100.0% (32 of 32 strings) Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/es/

Translated using Weblate (Italian)

4a425be

Currently translated at 100.0% (32 of 32 strings) Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/it/

Added translation using Weblate (French)

346372c

Translated using Weblate (French)

cef457b

Currently translated at 62.5% (20 of 32 strings) Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/fr/

Translated using Weblate (French)

5d52282

Currently translated at 75.0% (24 of 32 strings) Translation: storage-16.0/storage-16.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/fr/

[IMP] fs_base_multi_image: pre-commit auto fixes

3e671f5

[MIG] fs_base_multi_image: Migration to 17.0

934ba0e

[UPD] Update fs_base_multi_image.pot

ffed759

[BOT] post-merge updates

ac8a932

Update translation files

81970cb

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-17.0/storage-17.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_base_multi_image/

Translated using Weblate (Italian)

af24de8

Currently translated at 100.0% (33 of 33 strings) Translation: storage-17.0/storage-17.0-fs_base_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_base_multi_image/it/

benwillig and others added 7 commits February 19, 2025 16:43

[CHG] use list.addNew to add relation records instead of calling the …

86b7def

…ORM explicitely

[BOT] post-merge updates

44d83f7

[IMP] fs_base_multi_image: pre-commit autofixes

2aad575

[MIG] fs_base_multi_image: Migration to 18.0

9b1b5dd

[DONT MERGE] test-requirements.txt

6d9d2b4

[FIX] fs_base_multi_image: Call correct method name

3affe97

[IMP] fs_base_multi_image: Add tests

a4c96d1

rousseldenis force-pushed the 18.0-mig-fs-base-multi-image-dro branch from 11674c7 to a4c96d1 Compare February 20, 2025 10:58

rousseldenis mentioned this pull request Feb 20, 2025

[18.0][MIG] fs_product_multi_image #449

Open

[FIX] fs_base_multi_image: Use correct syntax

641ef9f

OCA-git-bot added this to the 18.0 milestone Feb 24, 2025

OCA-git-bot mentioned this pull request Feb 24, 2025

Migration to version 18.0 #398

Open

26 tasks

lmignon approved these changes Feb 24, 2025

View reviewed changes

youring approved these changes Feb 26, 2025

View reviewed changes

OCA-git-bot added approved labels Feb 26, 2025

youring suggested changes Feb 26, 2025

View reviewed changes

OCA-git-bot removed the approved label Feb 26, 2025

xaviedoanhduy suggested changes Apr 21, 2025

View reviewed changes

This was referenced Apr 23, 2025

[18.0][MIG] fs_product_public_category_multi_image: Migration to 18.0 #471

Open

[18.0][MIG] fs_import_image_advanced*: Migration to 18.0 #473

Open

kobros-tech suggested changes Jun 23, 2025

View reviewed changes

kobros-tech mentioned this pull request Aug 19, 2025

[MIG] fs_base_multi_image: Migration to 18.0 #506

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[18.0][MIG] fs_base_multi_image #447

[18.0][MIG] fs_base_multi_image #447

Uh oh!

rousseldenis commented Feb 20, 2025

Uh oh!

lmignon commented Feb 24, 2025

Uh oh!

lmignon left a comment

Uh oh!

youring left a comment

Uh oh!

youring Feb 26, 2025

Uh oh!

youring Feb 26, 2025

Uh oh!

xaviedoanhduy Apr 21, 2025

Uh oh!

kobros-tech left a comment

Uh oh!

lmignon commented Aug 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

	<field name="sequence" />
	<field name="sequence" widget="handle" />

	<field name="view_mode">tree,form</field>
	<field name="view_mode">list,form</field>

		from odoo.addons.base.tests.common import BaseCommon
		from odoo.addons.fs_image.fields import FSImageValue

Uh oh!

[18.0][MIG] fs_base_multi_image #447

Are you sure you want to change the base?

[18.0][MIG] fs_base_multi_image #447

Uh oh!

Conversation

rousseldenis commented Feb 20, 2025

Uh oh!

lmignon commented Feb 24, 2025

Uh oh!

lmignon left a comment

Choose a reason for hiding this comment

Uh oh!

youring left a comment

Choose a reason for hiding this comment

Uh oh!

youring Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

youring Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

xaviedoanhduy Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

kobros-tech left a comment

Choose a reason for hiding this comment

Uh oh!

lmignon commented Aug 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants