Skip to content

Conversation

@rousseldenis
Copy link
Contributor

lmignon and others added 30 commits February 20, 2025 12:56
Ensures the variant_image_ids are sorted by sequence and name. Before this
change, the order was random and could change between runs.
Currently translated at 100.0% (33 of 33 strings)

Translation: storage-16.0/storage-16.0-fs_product_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/es/
Currently translated at 100.0% (33 of 33 strings)

Translation: storage-16.0/storage-16.0-fs_product_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/it/
Currently translated at 100.0% (33 of 33 strings)

Translation: storage-16.0/storage-16.0-fs_product_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/it/
Currently translated at 100.0% (33 of 33 strings)

Translation: storage-16.0/storage-16.0-fs_product_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/it/
…th same label for image/image_1920 and image_medium/image_128 for product.template and product.product
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: storage-16.0/storage-16.0-fs_product_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/
Currently translated at 100.0% (34 of 34 strings)

Translation: storage-16.0/storage-16.0-fs_product_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: storage-16.0/storage-16.0-fs_product_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/
Currently translated at 100.0% (34 of 34 strings)

Translation: storage-16.0/storage-16.0-fs_product_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/es/
Currently translated at 76.4% (26 of 34 strings)

Translation: storage-16.0/storage-16.0-fs_product_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/fr/
@rousseldenis
Copy link
Contributor Author

@lmignon I've solved most of technical issues I've found.

The last one is that loaded images seem incoherent between display in product image tab and in the relation popup display:

image

Tested with runboat

@lmignon
Copy link
Contributor

lmignon commented Feb 24, 2025

/ocabot migration fs_product_multi_image

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 24, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 24, 2025
26 tasks
Comment on lines 51 to 56
<!-- <img
t-att-src="kanban_image('fs.product.image', 'image_medium', record.id.raw_value)"
t-if="record.id"
alt="Image"
class="o_image_64_contain"
/> -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code should be removed

<div class="o_kanban_image me-1">
<field
name="image_medium"
widget="image"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The widget to use is 'fs_image'

Suggested change
widget="image"
widget="fs_image"

With this change everything works properly on runboat.
image

@rousseldenis rousseldenis force-pushed the 18.0-mig-fs-product-multi-image-dro branch from 542c0ab to 0b539e1 Compare March 12, 2025 13:33
@rousseldenis rousseldenis force-pushed the 18.0-mig-fs-product-multi-image-dro branch from 0b539e1 to cd10cd9 Compare March 12, 2025 18:25
@kobros-tech
Copy link
Contributor

@lmignon I've solved most of technical issues I've found.

The last one is that loaded images seem incoherent between display in product image tab and in the relation popup display:

image

Tested with runboat

once you save the image you find the image itself is displayed instead of this placeholder image, I don't mind this behaviour.

Copy link
Contributor

@kobros-tech kobros-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although the conflict and test cases, I approve the migration.

@kobros-tech
Copy link
Contributor

@rousseldenis

do you need my help with test cases and merge conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants