-
-
Notifications
You must be signed in to change notification settings - Fork 199
[18.0][MIG] fs_product_multi_image #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
[18.0][MIG] fs_product_multi_image #449
Conversation
Ensures the variant_image_ids are sorted by sequence and name. Before this change, the order was random and could change between runs.
Currently translated at 100.0% (33 of 33 strings) Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/es/
Currently translated at 100.0% (33 of 33 strings) Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/it/
Currently translated at 100.0% (33 of 33 strings) Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/it/
Currently translated at 100.0% (33 of 33 strings) Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/it/
…th same label for image/image_1920 and image_medium/image_128 for product.template and product.product
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/
Currently translated at 100.0% (34 of 34 strings) Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/it/
… compare integer and NewId
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/
Currently translated at 100.0% (34 of 34 strings) Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/es/
… or there will be an owl error
Currently translated at 76.4% (26 of 34 strings) Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-17.0/storage-17.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_product_multi_image/
|
@lmignon I've solved most of technical issues I've found. The last one is that loaded images seem incoherent between display in product image tab and in the relation popup display: Tested with runboat |
|
/ocabot migration fs_product_multi_image |
| <!-- <img | ||
| t-att-src="kanban_image('fs.product.image', 'image_medium', record.id.raw_value)" | ||
| t-if="record.id" | ||
| alt="Image" | ||
| class="o_image_64_contain" | ||
| /> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code should be removed
| <div class="o_kanban_image me-1"> | ||
| <field | ||
| name="image_medium" | ||
| widget="image" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
542c0ab to
0b539e1
Compare
0b539e1 to
cd10cd9
Compare
once you save the image you find the image itself is displayed instead of this placeholder image, I don't mind this behaviour. |
kobros-tech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although the conflict and test cases, I approve the migration.
|
do you need my help with test cases and merge conflicts? |



Depends on: