Skip to content

[12.0][MIG] web_widget_x2many_2d_matrix#1101

Merged
yajo merged 58 commits into
OCA:12.0from
brainbeanapps:12.0-mig-web_widget_x2many_2d_matrix
Nov 20, 2018
Merged

[12.0][MIG] web_widget_x2many_2d_matrix#1101
yajo merged 58 commits into
OCA:12.0from
brainbeanapps:12.0-mig-web_widget_x2many_2d_matrix

Conversation

@alexey-pelykh

Copy link
Copy Markdown
Contributor

No description provided.

@pedrobaeza pedrobaeza added this to the 12.0 milestone Nov 9, 2018
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 9, 2018
40 tasks
@pedrobaeza

Copy link
Copy Markdown
Member

You should take into account opened PR for v11 #1014 + a current issue, which is #1084

@alexey-pelykh

Copy link
Copy Markdown
Contributor Author

Thanks for mentioning, I've subscribed to those to keep track of them. Any other special actions to take?

@pedrobaeza

Copy link
Copy Markdown
Member

Well, I have always missed an example embedded in this module as demo data, but it seems there's no good model for applying the 2d matrix without extra code.

@alexey-pelykh alexey-pelykh force-pushed the 12.0-mig-web_widget_x2many_2d_matrix branch from 0beaecd to bfa4dbb Compare November 9, 2018 16:55
@alexey-pelykh

Copy link
Copy Markdown
Contributor Author

@pedrobaeza #1014 taken into account

@pedrobaeza

Copy link
Copy Markdown
Member

There were a syntax error fixed here: 899f01f

@alexey-pelykh alexey-pelykh force-pushed the 12.0-mig-web_widget_x2many_2d_matrix branch from bfa4dbb to fa2969a Compare November 9, 2018 17:39
@alexey-pelykh

Copy link
Copy Markdown
Contributor Author

Cherry-picked 899f01f

@alexey-pelykh

Copy link
Copy Markdown
Contributor Author

@tarteo @yajo @jbeficent would like to ask for your review, if you don't mind

column totals. True by default

Example
=======

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ~~~~~~~

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simahawk simahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@yajo yajo merged commit 95b01b2 into OCA:12.0 Nov 20, 2018
@pedrobaeza

Copy link
Copy Markdown
Member

@yajo the README will give error due to bad underlining, so you shouldn't merge without fixing that.

@alexey-pelykh

Copy link
Copy Markdown
Contributor Author

Since it was merged, what should I do?

@alexey-pelykh

Copy link
Copy Markdown
Contributor Author

(readme generator didn't error on my side for some reason)

@yajo

yajo commented Nov 20, 2018

Copy link
Copy Markdown
Member

The syntax it produced is not exactly wrong syntax, so it shouldn't error.

@alexey-pelykh You can PR again to fix it.

@alexey-pelykh alexey-pelykh deleted the 12.0-mig-web_widget_x2many_2d_matrix branch November 20, 2018 08:44
@alexey-pelykh

Copy link
Copy Markdown
Contributor Author

@yajo @pedrobaeza #1106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.