Skip to content
This repository was archived by the owner on Feb 13, 2019. It is now read-only.

Issue #525 - Install sqlite3 at version required by EntityFramework. #530

Merged
merged 1 commit into from
Dec 8, 2015

Conversation

AlexChesser
Copy link
Contributor

In order to address an issue with running a sqlite3 database on aspnet-docker-linux
a version of sqlite3 must be installed that is greater than or equal to 3.7.15
which is not available on the default apt sources list in this image.
ref: dotnet/efcore#3089
aspnet/aspnet-docker#121

In order to address an issue with running a sqlite3 database on aspnet-docker-linux
a version of sqlite3 must be installed that is greater than or equal to 3.7.15
which is not available on the default apt sources list in this image.
ref: 	dotnet/efcore#3089
	aspnet/aspnet-docker#121
@peterblazejewicz
Copy link
Member

@AlexChesser
Thanks for the split. I've followed discussion on aspnet-docker as well, so I believe the stance to split PR was correct.
Will review your PR asap

@peterblazejewicz
Copy link
Member

note FYI, today I have to modify web section to get it running:

"commands": {
    "web": "Microsoft.AspNet.Server.Kestrel --server.urls http://0.0.0.0:5000",
    "ef": "EntityFramework.Commands"
  },

http://tattoocoder.azurewebsites.net/asp-net-5-continuous-integration-with-travis-ci-tutum-docker-webhooks-and-azure/

@peterblazejewicz
Copy link
Member

I've tested both Mono and CoreCLR based images and they works fine with that change.
The change is crucial to run EF template on Docker.
:shipit:

peterblazejewicz added a commit that referenced this pull request Dec 8, 2015
Issue #525 - Install sqlite3 at version required by EntityFramework.
This PR patches official aspnet-docker image with sqlite3 required by EntityFramework in web projects
Thanks @AlexChesser!
@peterblazejewicz peterblazejewicz merged commit 09396f4 into OmniSharp:master Dec 8, 2015
@peterblazejewicz
Copy link
Member

@sayedihashimi
It would be good to ship this change to NPM.
I'll make a tracking issue for RC2 release that will simplify Dockerfile back:
aspnet/aspnet-docker#122 (comment)

sesispla added a commit to sesispla/generator-aspnet that referenced this pull request Jun 12, 2016
peterblazejewicz pushed a commit that referenced this pull request Jun 14, 2016
🐳 🐋 🐳 Dockerfile for RC2. Closes #685
Thanks to @sesispla! 👯 

Added ConfigurationBuilder to WebHostBuilder for Dockerfile launch configuration
* Update Dockerfile test to RC2 (#685)
* Added ConfigurationBuilder to Empty Project template. Closes #685
* Removed apt-get source while #530 is fixed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants