SqlLite3 is out of date - EF crashes generated containers

[AlexChesser]

As enumerated in this open issue on the generator:

OmniSharp/generator-aspnet#525

The ASPNET docker image cannot successfully run the ASPNET generator as created by the YEOMAN generator.

Pull request incoming. Please feel free to let me know if you'd like it to be backported to prior releases (eg: beta8,7,... etc..)

[peterblazejewicz]

The topic subject is somehow misleading. The sqlite does not came preinstalled on Ubuntu and is not part of docker image install routines. The solution that works on Ubuntu 14.04 - provided by @AlexChesser, is to enforce non-custom package version download as required by EntityFramework:
OmniSharp/generator-aspnet#526 (comment)

@glennc @ahmetalpbalkan
Can you discuss if there is a possibility of incorporating sqlite3 as dependency to Ubuntu 14.04 based docker image for x-platform EntityFramework?
People are starting using a content promoted via generator-aspnet and the EntityFramework needs that package by default.
The samples on aspnet/home do no use EF, so there was never a use case for inclusing sqlite3.
Thanks!

[AlexChesser]

Hey @peterblazejewicz I think we'd find that this violates the intended purpose of the aspnet-docker image #123 (comment) which I'm told is "to be as bare bones as possible" (sic)

Adding slqite3 would violate "bare bones" in the case where databases are not needed or perhaps (in future) on the day where EF-x-platform gains connectors for other databases (mysql, postgres, vitesse) OR mssqlserver gets properly "containerized"

While users who are running generators likely want sqllite3, and the added cost of upgrading sqllite3 in the scope of omnisharp projects that don't need it may be minimal.

Or (as it seems you've already mentioned here: OmniSharp/generator-aspnet#526) someone could try to figure out how to if-else the inclusion of the update.

[glennc]

Can we split this into 2 PRs I'd like to talk about the two thing separately, pre-installing packages and SQLLite. The pre-installing packages can just be another file that inherits from the microsoft/aspnet right?

[ahmetb]

@glennc I believe we eliminated the need to pre-instal things with a tip I provided in #123 if I recall correctly.

[AlexChesser]

@glennc - the SQLLITE3 update is the only functionality in Pull request #122 I think I now have this in a condition that is acceptable to merge please let me know if you need any more cleanup or if you've got tips for "next time"

@ahmetalpbalkan - that's the "pre-cache dependencies" ticket - it seems the team over at omnisharp feel the sqllite3 update belongs over here.

[ahmetb]

Agreed.

[ahmetb]

The change is LGTM. @natemcmaster brought up this before as well (#85). @glennc/@natemcmaster can you please take a look and approve PR #122 as well?

[muratg]

Looks like this is done?

[AlexChesser]

Yup - done. Thanks @muratg!

[muratg]

Thanks @AlexChesser for the contribution!

[colltoaction]

Library is now at version 3.8.7.1: https://packages.debian.org/jessie/libsqlite3-dev. Should be OK to remove https://github.com/aspnet/aspnet-docker/blob/master/1.0.0-rc1-update1-coreclr/Dockerfile#L15

(see dotnet/efcore#3089 (comment))