Eliminate more instances of IWorkspaceOptionsProvider#2343
Merged
333fred merged 7 commits intoOmniSharp:masterfrom Mar 8, 2022
Merged
Eliminate more instances of IWorkspaceOptionsProvider#2343333fred merged 7 commits intoOmniSharp:masterfrom
333fred merged 7 commits intoOmniSharp:masterfrom
Conversation
1 task
Contributor
Author
tmat
force-pushed
the
OptionsExternalAccess
branch
from
6fa1003 to
e68fa67
Compare
tmat
force-pushed
the
OptionsExternalAccess
branch
from
e68fa67 to
741ea40
Compare
tmat
changed the title
333fred
reviewed
Feb 25, 2022
JoeRobich
force-pushed
the
OptionsExternalAccess
branch
from
625ebe1 to
9a8b09f
Compare
Member
333fred
reviewed
Mar 8, 2022
JoeRobich
approved these changes
Mar 8, 2022
333fred
approved these changes
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All options are now passed explicitly to the APIs that need them, except for default values for editorconfig-based formatting options. These will be eliminated later on.
Requires Roslyn changes: dotnet/roslyn#59469