Skip to content

Add external access APIs for O##59469

Merged
tmat merged 11 commits intodotnet:mainfrom
tmat:OmniSharpEA
Feb 23, 2022
Merged

Add external access APIs for O##59469
tmat merged 11 commits intodotnet:mainfrom
tmat:OmniSharpEA

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Feb 10, 2022

Corresponding O# PR: OmniSharp/omnisharp-roslyn#2343

Depends on dotnet/roslyn-sdk#967

TODO:

  • OmniSharpDocumentationCommentsSnippetService

@tmat tmat requested review from a team as code owners February 10, 2022 23:50
@ghost ghost added the Area-IDE label Feb 10, 2022
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Feb 10, 2022

@JoeRobich

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Feb 11, 2022

@JoeRobich @ryzngard One more commit to pass IDE analyzer options through (rebased on #58765).

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Feb 11, 2022

Turns out changes to Roslyn SDK are needed. dotnet/roslyn-sdk#967, dotnet/roslyn-sdk#969

@tmat tmat enabled auto-merge (squash) February 14, 2022 23:42
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Feb 16, 2022

#59575 needed to fix failing tests.

@tmat tmat disabled auto-merge February 22, 2022 23:45
@tmat tmat merged commit 03016af into dotnet:main Feb 23, 2022
@tmat tmat deleted the OmniSharpEA branch February 23, 2022 06:26
@ghost ghost added this to the Next milestone Feb 23, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants