Skip to content

Allow tests to customize FixAllContext#969

Merged
tmat merged 4 commits intodotnet:mainfrom
tmat:FixAllContext
Feb 22, 2022
Merged

Allow tests to customize FixAllContext#969
tmat merged 4 commits intodotnet:mainfrom
tmat:FixAllContext

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Feb 19, 2022

... and pass in internal options.

@tmat tmat requested a review from a team as a code owner February 19, 2022 20:58
@tmat tmat enabled auto-merge (rebase) February 19, 2022 22:24
Copy link
Copy Markdown
Contributor

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one CreateFixAllContext method should be virtual. If other overloads exist, they should ultimately delegate to the single virtual method.

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Feb 22, 2022

Removed the second overload.

@tmat tmat merged commit a42d204 into dotnet:main Feb 22, 2022
@tmat tmat deleted the FixAllContext branch February 22, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants