This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Add Devices directory with stub of LiquidCrystal_TC #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/Blink/Blink.ino
Outdated
| @@ -1,10 +1,10 @@ | |||
|
|
|||
There was a problem hiding this comment.
I think we should rename this file to the something more appropriate. TankController?
.github/workflows/Arduino-CI.yaml
Outdated
| @@ -20,6 +20,12 @@ jobs: | |||
| - run: | | |||
| bundle install | |||
|
|
|||
| # Creates the Library directory and install our libraries | |||
| - run: | | |||
| bundle exec ensure_arduino_installation.rb | |||
There was a problem hiding this comment.
Is this needed for running tests locally or only for the CI?
There was a problem hiding this comment.
Yes, we need to install custom libraries so it does make sense to have an install script that is called by the testing framework and is the one we can use as well.
Rename example and create install_libraries.sh script
jgfoster
pushed a commit
that referenced
this pull request
Nov 5, 2020
* Add Devices directory with stub of LiquidCrystal_TC (#6) Add LiquidCrystal_TC stub class and devices directory. * Set theme jekyll-theme-slate * Update index.md (#12) The start of using github pages as documentation. * Move scripts into scripts directory. (#13) * Added Class and Tests for Serial (#10) Co-authored-by: Khalil Llewellyn <[email protected]> Co-authored-by: James Foster <[email protected]> Co-authored-by: Preston Carman <[email protected]> Co-authored-by: Preston Carman <[email protected]> Co-authored-by: khalilxl <[email protected]> Co-authored-by: Khalil Llewellyn <[email protected]>
jgfoster
pushed a commit
that referenced
this pull request
Nov 16, 2020
* Add Devices directory with stub of LiquidCrystal_TC (#6) * Add LiquidCrystal_TC stub class and devices directory. * Add EEPROM encapsulation * Organized functions and added testing * continuing work, still have warnings and errors Co-authored-by: James Foster <[email protected]> Co-authored-by: Elizabeth Ventura <[email protected]>
jgfoster
pushed a commit
that referenced
this pull request
Nov 16, 2020
Allow for further testing/development of EEPROM * Add Devices directory with stub of LiquidCrystal_TC (#6) * Add LiquidCrystal_TC stub class and devices directory. * Set theme jekyll-theme-slate * Update index.md (#12) * The start of using github pages as documentation. * Move scripts into scripts directory. (#13) * Added Class and Tests for Serial (#10) * Use custom `arduino_ci` with fixes we need (#17) * Explicitly install libraries (#18) * Meeting notes. * Documentation using Doxygen (#20) * Saving automated documentation to gh-pages branch using Doxygen * Restrict to pushing documentation to changes on master * Updating comments for Doxygen (#21) * Fixed formatting * Update to latest `arduino_ci`; cleanup library install * Change check for are we in CI to not rely on (missing) `ARDUINO_CI` macro. Co-authored-by: Preston Carman <[email protected]> Co-authored-by: Preston Carman <[email protected]> Co-authored-by: James Foster <[email protected]> Co-authored-by: Khalil Llewellyn <[email protected]> Co-authored-by: khalilxl <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will be creating wrappers for the external libraries and this provides an initial stub.