This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Added Class and Tests for Serial #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgfoster
reviewed
Nov 3, 2020
.vscode/settings.json
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
It doesn't seem that this file association should be necessary. In any case, please update .gitignore to remove lines 4-7 so that this isn't part of your PR.
jgfoster
reviewed
Nov 3, 2020
jgfoster
reviewed
Nov 3, 2020
jgfoster
reviewed
Nov 3, 2020
jgfoster
reviewed
Nov 3, 2020
| assertEqual("btest:\r\ntest:3\r\n", state->serialPort[0].dataOut); | ||
| } | ||
|
|
||
| unittest_main() |
There was a problem hiding this comment.
We should have tests for each of the public API functions. It wouldn't take much to add a few more.
jgfoster
reviewed
Nov 3, 2020
Finish tests and reset output between each.
Refactor DateTime to add zeros and use helper function.
prestoncarman
approved these changes
Nov 4, 2020
jgfoster
pushed a commit
that referenced
this pull request
Nov 5, 2020
* Add Devices directory with stub of LiquidCrystal_TC (#6) Add LiquidCrystal_TC stub class and devices directory. * Set theme jekyll-theme-slate * Update index.md (#12) The start of using github pages as documentation. * Move scripts into scripts directory. (#13) * Added Class and Tests for Serial (#10) Co-authored-by: Khalil Llewellyn <[email protected]> Co-authored-by: James Foster <[email protected]> Co-authored-by: Preston Carman <[email protected]> Co-authored-by: Preston Carman <[email protected]> Co-authored-by: khalilxl <[email protected]> Co-authored-by: Khalil Llewellyn <[email protected]>
jgfoster
pushed a commit
that referenced
this pull request
Nov 16, 2020
Allow for further testing/development of EEPROM * Add Devices directory with stub of LiquidCrystal_TC (#6) * Add LiquidCrystal_TC stub class and devices directory. * Set theme jekyll-theme-slate * Update index.md (#12) * The start of using github pages as documentation. * Move scripts into scripts directory. (#13) * Added Class and Tests for Serial (#10) * Use custom `arduino_ci` with fixes we need (#17) * Explicitly install libraries (#18) * Meeting notes. * Documentation using Doxygen (#20) * Saving automated documentation to gh-pages branch using Doxygen * Restrict to pushing documentation to changes on master * Updating comments for Doxygen (#21) * Fixed formatting * Update to latest `arduino_ci`; cleanup library install * Change check for are we in CI to not rely on (missing) `ARDUINO_CI` macro. Co-authored-by: Preston Carman <[email protected]> Co-authored-by: Preston Carman <[email protected]> Co-authored-by: James Foster <[email protected]> Co-authored-by: Khalil Llewellyn <[email protected]> Co-authored-by: khalilxl <[email protected]>
|
@all-contributors please add @khalilxl for code |
|
I've put up a pull request to add @khalilxl! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had some trouble running tests because of Blink.cpp