Skip to content

[Bug]: windows install script is brittle #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abrichr opened this issue Jul 10, 2023 · 1 comment · Fixed by #409
Closed

[Bug]: windows install script is brittle #372

abrichr opened this issue Jul 10, 2023 · 1 comment · Fixed by #409
Assignees
@KrishPatel13
Labels
bug Something isn't working

Comments

@abrichr
Copy link
Member

abrichr commented Jul 10, 2023

Describe the bug

I experienced a few issues running the windows installation script:

  1. Any version of git should work

image

  1. When the user declines to update git, the installation should continue:

image

  1. When the script exits, ideally there should be some sort of message:
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

Install the latest PowerShell for new features and improvements! https://aka.ms/PSWindows

PS C:\Users\erika> Start-Process powershell -Verb RunAs -ArgumentList '-NoExit', '-ExecutionPolicy', 'Bypass', '-Command', "iwr -UseBasicParsing -Uri 'https://raw.githubusercontent.com/MLDSAI/OpenAdapt/main/install/install_openadapt.ps1' | Invoke-Expression"
PS C:\Users\erika>
  1. Ideally we should support any version of python greater or equal to 3.10

image

  1. Running poetry shell sometimes fails with this message:

image

  1. Trying to activate it fails, even though it hasn't been activated:

image
image

To Reproduce

See above
@abrichr abrichr added the bug Something isn't working label Jul 10, 2023
@KrishPatel13 KrishPatel13 mentioned this issue Jul 19, 2023
Merged
13 tasks
@KrishPatel13 KrishPatel13 self-assigned this Jul 19, 2023
@KrishPatel13
Copy link
Collaborator

made a PR here: #409

@KrishPatel13 KrishPatel13 linked a pull request Jul 19, 2023 that will close this issue
fix(install): improve powershell script (Issue #372) #409
Merged
13 tasks
abrichr added a commit that referenced this issue Jul 25, 2023
@KrishPatel13 @abrichr
fix(install): improve powershell script (Issue #372) (#409)
fb3ae1e 
* fix: git reinstallation even if it si present

* fix: Error Message:

Remove-Item : Cannot remove the item at 'C:\Users\Krish Patel\hi' because it is in
use.
At line:1 char:9
+         Remove-Item -LiteralPath $setupdir -Force -Recurse
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [Remove-Item], PSInvalidOperation
   Exception
    + FullyQualifiedErrorId : InvalidOperation,Microsoft.PowerShell.Commands.RemoveIt
   emCommand

* fix: issue that poetry shell gives
"..runnning scripts is disabled on the command line"

* fix: bug #4 issue
 to support multiple version of python (acc. to OpenAdapt standards)

* add start mesage to know
 why sometimes the installtion command exits

* fix the edge case where the new terminal PWD
 is not set to the OpenAdapt folder that was installed

* Update install/install_openadapt.ps1

---------

Co-authored-by: Richard Abrich <[email protected]>
@ayewo ayewo mentioned this issue Jul 31, 2023
Open
R-ohit-B-isht pushed a commit to R-ohit-B-isht/OpenAdapt that referenced this issue Jun 21, 2024
@KrishPatel13 @abrichr
fix(install): improve powershell script (Issue OpenAdaptAI#372) (Open…
8ca807a 
…AdaptAI#409)

* fix: git reinstallation even if it si present

* fix: Error Message:

Remove-Item : Cannot remove the item at 'C:\Users\Krish Patel\hi' because it is in
use.
At line:1 char:9
+         Remove-Item -LiteralPath $setupdir -Force -Recurse
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [Remove-Item], PSInvalidOperation
   Exception
    + FullyQualifiedErrorId : InvalidOperation,Microsoft.PowerShell.Commands.RemoveIt
   emCommand

* fix: issue that poetry shell gives
"..runnning scripts is disabled on the command line"

* fix: bug #4 issue
 to support multiple version of python (acc. to OpenAdapt standards)

* add start mesage to know
 why sometimes the installtion command exits

* fix the edge case where the new terminal PWD
 is not set to the OpenAdapt folder that was installed

* Update install/install_openadapt.ps1

---------

Co-authored-by: Richard Abrich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KrishPatel13 KrishPatel13

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(install): improve powershell script (Issue #372) KrishPatel13/OpenAdapt
2 participants
@abrichr @KrishPatel13