-
-
Notifications
You must be signed in to change notification settings - Fork 183
fix(install): improve powershell script (Issue #372) #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove-Item : Cannot remove the item at 'C:\Users\Krish Patel\hi' because it is in use. At line:1 char:9 + Remove-Item -LiteralPath $setupdir -Force -Recurse + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (:) [Remove-Item], PSInvalidOperation Exception + FullyQualifiedErrorId : InvalidOperation,Microsoft.PowerShell.Commands.RemoveIt emCommand
"..runnning scripts is disabled on the command line"
Bug 4 (from #372 (comment)) Resolution Transcript (f39c583):
|
Bug 1 and 2 (from #372 (comment)): Resolution Commit: ed7f3e0 Resolution Transcript: Some Improvement in Old Function Terminal Transcript:
Updated Function Code for Terminal Transcript:
Updated code for the function:
Conclusion: The previous old function was incorrect and did not work as expected on Unit Testing as shown in the transcripts. |
Bug 5 and 6 (from #372 (comment)): Resolution Commit: cf0d21d Resolution Documentation: |
why sometimes the installtion command exits
Update: Commit: 56cf2c1 |
is not set to the OpenAdapt folder that was installed
@abrichr Ready for review! |
@abrichr Ready for Final Review and merging! :) |
…AdaptAI#409) * fix: git reinstallation even if it si present * fix: Error Message: Remove-Item : Cannot remove the item at 'C:\Users\Krish Patel\hi' because it is in use. At line:1 char:9 + Remove-Item -LiteralPath $setupdir -Force -Recurse + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (:) [Remove-Item], PSInvalidOperation Exception + FullyQualifiedErrorId : InvalidOperation,Microsoft.PowerShell.Commands.RemoveIt emCommand * fix: issue that poetry shell gives "..runnning scripts is disabled on the command line" * fix: bug #4 issue to support multiple version of python (acc. to OpenAdapt standards) * add start mesage to know why sometimes the installtion command exits * fix the edge case where the new terminal PWD is not set to the OpenAdapt folder that was installed * Update install/install_openadapt.ps1 --------- Co-authored-by: Richard Abrich <[email protected]>
What kind of change does this PR introduce?
This PR resolves the bugs numbered here #372 (comment)
Summary
Bug Number fixed:
Checklist
How can your code be run and tested?
Other information