Fix memory leak of pserver #10173
Merged
Fix memory leak of pserver #10173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
approved these changes
Apr 24, 2018
Contributor
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
LGTM, Thanks for finding this bug, it should be hard.
panyx0718
reviewed
Apr 24, 2018
| DestroyCallback destroy_callback = [](void* backing) {}; | ||
|
|
||
| void* buf = malloc(1024); | ||
| auto buffer = std::unique_ptr<char[]>(new char[1024]); |
Contributor
There was a problem hiding this comment.
I think it's ok for now. Is it possible to statically create it? Maybe it's faster?
char char_buf[1024];
void* buffer = static_cast<void*>(char_buf)?
Contributor
Author
There was a problem hiding this comment.
Maybe it change to be larger later? ^_^
panyx0718
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10155