Skip to content

Fix memory leak of pserver #10173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gongweibao merged 3 commits into from
Apr 24, 2018
Merged

Fix memory leak of pserver #10173

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
220587f
fix
gongweibao Apr 24, 2018
75b4e8c
add
gongweibao Apr 24, 2018
d19631a
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
gongweibao Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion paddle/fluid/operators/detail/sendrecvop_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ void SerializeToByteBuffer(const std::string& name, framework::Variable* var,
// parallelism execution, need to know when to free the tensor.
DestroyCallback destroy_callback = [](void* backing) {};

void* buf = malloc(1024);
auto buffer = std::unique_ptr<char[]>(new char[1024]);
Copy link
Contributor

@panyx0718 panyx0718 Apr 24, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok for now. Is it possible to statically create it? Maybe it's faster?
char char_buf[1024];
void* buffer = static_cast<void*>(char_buf)?

Copy link
Contributor Author

@gongweibao gongweibao Apr 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it change to be larger later? ^_^

void* buf = buffer.get();

void* payload = nullptr;
size_t payload_size;
ProtoEncodeHelper e(static_cast<char*>(buf), 1024);
Expand Down