-
Notifications
You must be signed in to change notification settings - Fork 5.9k
reduce travis-ci time of build_doc #3310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wangkuiyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| SOURCE_BRANCH="master" | ||
|
|
||
| # Clone the repo to output directory | ||
| mkdir output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use rm -rf output here? It seems that rmdir output works only when output is an empty directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the next line git clone $REPO output , we remain mkdir output here.
| cd $TRAVIS_BUILD_DIR/build | ||
|
|
||
| # Compile paddle binaries first | ||
| cmake .. -DCMAKE_BUILD_TYPE=Debug -DWITH_GPU=OFF -DWITH_DOC=OFF -DWITH_MKLDNN=OFF -DWITH_MKLML=OFF -DWITH_GOLANG=ON -DWITH_STYLE_CHECK=OFF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. Does this mean that the build_doc Travis job doesn't build Paddle twice now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, build_doc Travis Job doesn't build twice, and doesn't build the whole Paddle now.
|
Travis CI's build_doc jobs failed: I tried to help fixing it, but no idea how to do it. |
|
There are some other places that import py_paddle, and I'm afraid that building of $ grep -r py_paddle *
paddle/v2/data_feeder.py:from py_paddle import DataProviderConverter
paddle/v2/data_feeder.py: :type argument: py_paddle.swig_paddle.Arguments
paddle/v2/inference.py: import py_paddle.swig_paddle as api
paddle/v2/parameters.py: import py_paddle.swig_paddle as api
paddle/v2/parameters.py: import py_paddle.swig_paddle as api
paddle/v2/parameters.py: import py_paddle.swig_paddle as api
paddle/v2/__init__.py: import py_paddle.swig_paddle as api
paddle/v2/event.py: import py_paddle.swig_paddle as api
paddle/v2/tests/test_parameters.py: import py_paddle
paddle/v2/tests/test_parameters.py: del py_paddle
paddle/v2/tests/test_data_feeder.py:import py_paddle.swig_paddle as api
paddle/v2/optimizer.py: import py_paddle.swig_paddle as swig_api
paddle/v2/optimizer.py: import py_paddle.swig_paddle as swig_api
paddle/v2/optimizer.py: import py_paddle.swig_paddle as swig_api
paddle/v2/optimizer.py: import py_paddle.swig_paddle as swig_api
paddle/v2/optimizer.py: import py_paddle.swig_paddle as swig_api
paddle/v2/optimizer.py: import py_paddle.swig_paddle as swig_api
paddle/v2/trainer.py: import py_paddle.swig_paddle as api
paddle/v2/trainer.py: import py_paddle.swig_paddle as api
paddle/v2/trainer.py: import py_paddle.swig_paddle as api |
|
@wangkuiyi @Xreki When building the document, it only read |
* remove external_project_dependencies for proto/CMakeLists.txt
|
@Xreki |
|
The travis time of |
fix #3303
related #1854
import py_paddlenow, thus, removeimport py_paddlein both conf.py.cn.in and conf.py.en.inimport paddle, we can use'@PROJ_ROOT@/python/paddleinstead of installing paddle python package, which will reduce a lot of time.build_doc in Dockerfile (build.sh) will be updated in next PR.