Skip to content

Conversation

@luotao1
Copy link
Contributor

@luotao1 luotao1 commented Aug 15, 2017

As building documentation don't need to install Paddle before (#3310 merged), refine the paddle/scripts/docker/build.sh

@luotao1 luotao1 requested a review from typhoonzero August 15, 2017 03:09
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add print some information at the end of the build like "If you need to install paddle in develop docker image, please run xxx"

@luotao1
Copy link
Contributor Author

luotao1 commented Aug 15, 2017

@typhoonzero Done.

Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@luotao1 luotao1 merged commit d605560 into PaddlePaddle:develop Aug 15, 2017
@luotao1 luotao1 deleted the docker_doc branch August 15, 2017 06:01
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
* fix warning when result is empty

* fix warning when result is empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants