Skip to content

Conversation

@wanghaoshuang
Copy link
Contributor

fix #4421

@wanghaoshuang wanghaoshuang changed the title Fix InferShape of clip op. Fix doc of clip op. Sep 27, 2017
AddInput("X",
"(Tensor)The input of clip op."
"The input should be a k-D tensor(k > 0 and k < 7)");
"The dimension size of input tensor must be between [1, 9].");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dimension size => number of dimensions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.

namespace paddle {
namespace operators {

using framework::LoDTensor;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems not needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.

Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghaoshuang wanghaoshuang merged commit 3e96242 into PaddlePaddle:develop Sep 27, 2017
@wanghaoshuang wanghaoshuang deleted the fix_clip branch September 27, 2017 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix doc of clip op.

2 participants