Skip to content

Fix doc of clip op. #4422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghaoshuang merged 3 commits into from
Sep 27, 2017
Merged

Fix doc of clip op. #4422

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0289738
Fix InferShape of clip op.
wanghaoshuang Sep 27, 2017
6da5670
revert deleting ShareLoD
wanghaoshuang Sep 27, 2017
1ad4efa
Fix comments
wanghaoshuang Sep 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions paddle/operators/clip_op.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
namespace paddle {
namespace operators {

using framework::LoDTensor;
Copy link
Contributor

@typhoonzero typhoonzero Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems not needed?

Copy link
Contributor Author

@wanghaoshuang wanghaoshuang Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.


class ClipOp : public framework::OperatorWithKernel {
public:
using framework::OperatorWithKernel::OperatorWithKernel;
Expand All @@ -28,8 +30,8 @@ class ClipOp : public framework::OperatorWithKernel {
PADDLE_ENFORCE(ctx->HasOutput("Out"),
"Output(Out) of ClipOp should not be null.");
auto x_dims = ctx->GetInputDim("X");
auto max = ctx->Attrs().Get<float>("max");
auto min = ctx->Attrs().Get<float>("min");
auto max = Attr<float>("max");
auto min = Attr<float>("min");
PADDLE_ENFORCE_LT(min, max, "max should be greater than min.");
ctx->SetOutputDim("Out", x_dims);
ctx->ShareLoD("X", /*->*/ "Out");
Expand All @@ -43,7 +45,7 @@ class ClipOpMaker : public framework::OpProtoAndCheckerMaker {
: OpProtoAndCheckerMaker(proto, op_checker) {
AddInput("X",
"(Tensor)The input of clip op."
"The input should be a k-D tensor(k > 0 and k < 7)");
"The dimension size of input tensor must be between [1, 9].");
Copy link
Contributor

@typhoonzero typhoonzero Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dimension size => number of dimensions

Copy link
Contributor Author

@wanghaoshuang wanghaoshuang Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.

AddOutput("Out", "(Tensor)The output of clip op with shape as input(X)");
AddAttr<AttrType>(
"min", "(float)Minimum value, under which element is replaced by min.");
Expand Down