Add CUDA kernel for prior_box_op. #9553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const T step_height, const T* min_sizes, | ||
| const T* max_sizes, const int min_num, | ||
| bool is_clip) { | ||
| int num_priors = max_sizes ? as_num * min_num + min_num : as_num * min_num; |
Contributor
Author
There was a problem hiding this comment.
想少传递一些参数，就在kernel里也计算了下。
max_sizes 和 min_sizes的个数是相等的。 https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/fluid/operators/prior_box_op.cc#L52 这里有check。 所以这里就直接 + min_num。
| int w = (i / num_priors) % width; | ||
| int p = i % num_priors; | ||
| int m = max_sizes ? p / (as_num + 1) : p / as_num; | ||
| T cx = (w + offset) * step_width; |
Contributor
There was a problem hiding this comment.
第一个box就需要乘上step_width么？
请忽略，我看caffe也是这样写的。
Contributor
Author
There was a problem hiding this comment.
Yeah, each box needs to mul step_width https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/gserver/layers/PriorBox.cpp#L105
chengduoZH
reviewed
Apr 3, 2018
| @@ -0,0 +1,167 @@ | |||
| /* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserved. | |||
| namespace operators { | ||
|
|
||
| template <typename T> | ||
| __device__ inline T clip(T in) { |
chengduoZH
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9472