Skip to content

Add NullCacheAdapter #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions spec/NullCacheAdapter.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
var NullCacheAdapter = require('../src/Adapters/Cache/NullCacheAdapter').default;

describe('NullCacheAdapter', function() {
var KEY = 'hello';
var VALUE = 'world';

it('should expose promisifyed methods', (done) => {
var cache = new NullCacheAdapter({
ttl: NaN
});

// Verify all methods return promises.
Promise.all([
cache.put(KEY, VALUE),
cache.del(KEY),
cache.get(KEY),
cache.clear()
]).then(() => {
done();
});
});

it('should get/set/clear', (done) => {
var cache = new NullCacheAdapter({
ttl: NaN
});

cache.put(KEY, VALUE)
.then(() => cache.get(KEY))
.then((value) => expect(value).toEqual(null))
.then(() => cache.clear())
.then(() => cache.get(KEY))
.then((value) => expect(value).toEqual(null))
.then(done);
});

});
1 change: 1 addition & 0 deletions spec/index.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ describe('server', () => {
expect(ParseServer.GCSAdapter).toThrow('GCSAdapter is not provided by parse-server anymore; please install parse-server-gcs-adapter');
expect(ParseServer.FileSystemAdapter).toThrow();
expect(ParseServer.InMemoryCacheAdapter).toThrow();
expect(ParseServer.NullCacheAdapter).toThrow();
done();
});

Expand Down
25 changes: 25 additions & 0 deletions src/Adapters/Cache/NullCacheAdapter.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
export class NullCacheAdapter {

constructor(ctx) {
}

get(key) {
return new Promise((resolve, _) => {
return resolve(null);
})
}

put(key, value, ttl) {
return Promise.resolve();
}

del(key) {
return Promise.resolve();
}

clear() {
return Promise.resolve();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix it.

}

export default NullCacheAdapter;
3 changes: 2 additions & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import ParseServer from './ParseServer';
import S3Adapter from 'parse-server-s3-adapter'
import FileSystemAdapter from 'parse-server-fs-adapter'
import InMemoryCacheAdapter from './Adapters/Cache/InMemoryCacheAdapter'
import NullCacheAdapter from './Adapters/Cache/NullCacheAdapter'
import TestUtils from './TestUtils';
import { useExternal } from './deprecated';
import { getLogger } from './logger';
Expand All @@ -21,4 +22,4 @@ Object.defineProperty(module.exports, 'logger', {
});

export default ParseServer;
export { S3Adapter, GCSAdapter, FileSystemAdapter, InMemoryCacheAdapter, TestUtils, _ParseServer as ParseServer };
export { S3Adapter, GCSAdapter, FileSystemAdapter, InMemoryCacheAdapter, NullCacheAdapter, TestUtils, _ParseServer as ParseServer };