Add NullCacheAdapter

[yuki-takeichi]

NullCacheAdapter disables in-memory cache explicitly in order to prevent cache inconsistency between multiple servers.

[yuki-takeichi]

Tests failed but it is not my fault.

[codecov-io]

Current coverage is 92.12% (diff: 100%)

Merging #2636 into master will increase coverage by 0.04%

@@             master      #2636   diff @@
==========================================
  Files            99        101     +2   
  Lines         12113      12304   +191   
  Methods        1488       1529    +41   
  Messages          0          0          
  Branches       1996       2022    +26   
==========================================
+ Hits          11154      11335   +181   
- Misses          959        969    +10   
  Partials          0          0          

Powered by Codecov. Last update ac11e03...c456ced

[flovilmart]

@yuki-takeichi thanks for the PR. We're cautious adding come additional adapter to the main code base. The biggest pain point is that to access them, you need to know the internal path of that said adapter and that prevent maintainers from doing extra refactoring (like what happened to the FileLoggerAdapter when renamed to WinstonLoggerAdapter).

I know it's a lot to ask, but could you add a module that would be accessed with:

const NullCacheAdapter = require('parse-server').NullCacheAdapter;

Do you think that's possible?

Thanks.

[flovilmart]

clear don't return a https://github.com/ParsePlatform/parse-server/pull/2636/files#diff-99cd8e4151bc9033636e69ac0fd61902R12

[yuki-takeichi]

I'll fix it.

[ghost]

@yuki-takeichi updated the pull request - view changes

[ghost]

@yuki-takeichi updated the pull request - view changes

[yuki-takeichi]

@flovilmart
Thanks for reviewing!
Is c456ced what you want?

BTW, I can't find out the reason why
https://github.com/ParsePlatform/parse-server/blob/master/spec/index.spec.js#L250
is correct behavior.
So I don't have confidence to add this line: c456ced#diff-34eeea22d611a12d47230ee1ebae43ffR251.
Cloud you please tell me why Parse.InMemoryCacheAdapter and other adapters are expected to throw here?

Regards,

[flovilmart]

That looks good to me.

[flovilmart]

It throws something like: TypeError: Cannot call a class as a function as it's a class called as a function. We may wanna be more expressive :)