Updating to angular2-*@2.0.0-rc6 (deps, specs ...) #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gdi2290 I have updated to RC6. There seems to be an issue with the |
katallaxie
changed the title
|
@katallaxie there always seems to be a problem with |
| @@ -17,7 +17,6 @@ export const routes = [ | |||
| Detail | |||
| ], | |||
| imports: [ | |||
| BrowserModule, | |||
| FormsModule, | |||
There was a problem hiding this comment.
don't you need CommonModule here?
There was a problem hiding this comment.
I have included it again. But BrowserModule is already imported in app.module.ts.
Closed
awcodify
pushed a commit
to awcodify/d3-angular-4
that referenced
this pull request
Aug 28, 2017
* ~ adding angular-*@2.0.0-rc6 * ~ fixing .specs for angular-*@2.0.0-rc6 * ~ removing comment from x-large spec * ~ remove old module from +detail and adding again CommonModule * ~ disabling DedupePlugin (angular/angular-cli#1587)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular 2 RC6
Angular 2 RC5