Add exit code test (GH #19020): #19152
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests that when we kill a process through a shell, we get the correct exit code and signal.
Unfortunately, this fails on some versions of Ubuntu and
dash
, which I believe shows a bug somewhere. This PR cannot be merged until that is resolved one way (like fixing it in the core) or another (like turning this into aTODO
or something). I'm hoping to get some smoke tests from this to provide more information.There's a
sleep()
included because some systems might delay the signal until the-e''
execution would already finish.