Add exit code test (refurbish p.r. 19152 for issue 19020) #22545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests that when we kill a process through a shell, we get the correct exit code and signal. Unfortunately, this fails on some versions of Ubuntu and dash, which I believe shows a bug somewhere. There's a sleep() included because some systems might delay the signal until the -e'' execution would already finish. Resubmission: Resolve merge conflicts in MANIFEST. Trim description for new file therein.
I should have added: I expect several failures in the newly added test file, but once we see the scope of such failures we can decide how/whether to proceed. |
Tests 2-4 are failing on Linux, which means that our GH Actions testing gets short-circuited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch and p.r. exist in order to get come clean data on the problem originally described by @xsawyerx in #19020, who then submitted a p.r. in #19152. I have created new branch from that p.r., rebased on blead, with corrected MANIFEST,and titled it in order to trigger smoke-me tests.