Avoid using deprecated manifest fields #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <returns>A List of diagnostic results of this rule</returns> | ||
| public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName) | ||
| { | ||
| if (ast == null) throw new ArgumentNullException(Strings.NullAstErrorMessage); |
There was a problem hiding this comment.
Braces for conditional statements
| @{ | ||
|
|
||
| # Script module or binary module file associated with this manifest. | ||
| ModuleToProcess ='scriptanalyzer' |
| { | ||
| foreach (var warning in result) | ||
| { | ||
| yield return new DiagnosticRecord(String.Format(CultureInfo.CurrentCulture, warning.BaseObject.ToString()), ast.Extent, GetName(), DiagnosticSeverity.Warning, fileName); |
There was a problem hiding this comment.
Is there going to be a null pointer exception if the baseobject is null? If I remember correctly, we got this bug somewhere before.
There was a problem hiding this comment.
Thanks. I've added a null check for that.
|
I've compared the manifest file generated by PS V2.0 and V5.0 and seems like the only deprecated field is "ModuleToProcess". PSV5.0 introduced new fields such as "DscResourcesToExport".. I've updated the error description. |
|
Signoff |
yutingc
added a commit
that referenced
this pull request
May 19, 2015
…ields Avoid using deprecated manifest fields
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.