Skip to content

Merge development branch into master #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 20, 2015
Merged

Conversation

quoctruong
Copy link

No description provided.

raghushantha and others added 15 commits June 2, 2015 11:36
Take latest Master to Development
Take latest Master to Development
This change refactors the existing codebase to move all
logic into the ScriptAnalyzer class.
Refactor Script Analyzer to be used as a .NET library
Added an about help topic file and fixed a typo in rule description
Implement GlobalSuppression for ScriptAnalyzer
The default implementation of MEF's DirectoryCatalog does not
handle ReflectionTypeLoadExceptions that occur when assemblies
in the specified directory are loaded.  This causes the full
assembly loading process to stop, meaning that no rules will
be found.  When running Script Analyzer in a folder with a lot
of DLLs, this type of error becomes more likely.  This change
introduces a new SafeDirectoryCatalog type which is more resilient
to this problem.

Also, there is a check that determines whether any rules have
been loaded before continuing.  This check was prone to throwing
NullReferenceExceptions when MEF composition fails.  I changed
that logic to be more resilient to potential null values.
Handle assembly loading errors at composition time
@raghushantha
Copy link
Member

looks good! pls merge

@quoctruong
Copy link
Author

Thanks. Merged

quoctruong pushed a commit that referenced this pull request Jul 20, 2015
@quoctruong quoctruong merged commit 1c579c3 into master Jul 20, 2015
@raghushantha raghushantha deleted the mergedevelopmentintomaster branch August 25, 2015 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants