-
Notifications
You must be signed in to change notification settings - Fork 395
Merge development branch into master #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take latest Master to Development
Take latest Master to Development
…iCmdlet rule description.
…ING SCRIPT ANALYZER sections.
This change refactors the existing codebase to move all logic into the ScriptAnalyzer class.
Refactor Script Analyzer to be used as a .NET library
Added an about help topic file and fixed a typo in rule description
Implement GlobalSuppression for ScriptAnalyzer
The default implementation of MEF's DirectoryCatalog does not handle ReflectionTypeLoadExceptions that occur when assemblies in the specified directory are loaded. This causes the full assembly loading process to stop, meaning that no rules will be found. When running Script Analyzer in a folder with a lot of DLLs, this type of error becomes more likely. This change introduces a new SafeDirectoryCatalog type which is more resilient to this problem. Also, there is a check that determines whether any rules have been loaded before continuing. This check was prone to throwing NullReferenceExceptions when MEF composition fails. I changed that logic to be more resilient to potential null values.
Handle assembly loading errors at composition time
looks good! pls merge |
Thanks. Merged |
quoctruong
pushed a commit
that referenced
this pull request
Jul 20, 2015
Merge development branch into master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.