Skip to content

[Ignore] Use PowerShell download script for Travis builds #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Oct 9, 2018

Updates our travis configuration to use the latest PowerShell and not 6.0.0-beta, which was breaking in Ubuntu Trusty.

@rjmholt rjmholt requested a review from rkeithhill October 9, 2018 21:51
Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - simplicity FTW. That said, I don't know much about that download bash script so take my LGTM with a grain of salt. :-)

@rjmholt
Copy link
Contributor Author

rjmholt commented Oct 10, 2018

@rkeithhill Tbh I don't all that much about it either. I think the current implementation it all uses was written by @DarwinJS anyway. But, it's heavily relied on in the PowerShell repos, so it makes sense to deduplicate and trust it (we already do in vscode-PowerShell I'm pretty sure).

@rjmholt rjmholt merged commit 105096a into PowerShell:master Oct 10, 2018
@rjmholt rjmholt deleted the use-latest-pwsh-travis branch December 12, 2018 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants