Fix crash where edits up to the end of the file do not work #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis failure is because our ancient Travis powershell version is now broken on Trusty Tahr. Fixed in #764. |
|
Does #784 fix this instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#1561.
We now handle edit messages that go up to the end of the file properly.
Previously we would get a message with a non-empty insertion that went up to 1 past the current line in the VSCode buffer. We handled the empty case as a simple deletion, but we now handle the edit case too.
I split out the function handling this so it uses
returnrather than complicated nestingifs -- then the caller handles theParseFileContentsmethod after.