Rewrite release signing pipeline #3162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
andyleejordan
commented
Feb 4, 2021
andyleejordan
force-pushed
the
andschwa/esrp
branch
4 times, most recently
from
3556508 to
0d47940
Compare
rjmholt
approved these changes
Feb 9, 2021
andyleejordan
force-pushed
the
andschwa/esrp
branch
2 times, most recently
from
212d5ff to
5bad55a
Compare
andyleejordan
commented
Feb 9, 2021
andyleejordan
force-pushed
the
andschwa/esrp
branch
2 times, most recently
from
a3fe52c to
61e800d
Compare
This isn't done, but I need to start a pipeline run to see where it's at.
We changed the upstream pipeline to use the `publish` task which publishes _pipeline_ artifacts, not _build_ artifacts, which means this task needed to be updated.
Since Visual Studio Code extensions cannot be signed. We originally tried signing the extension because it was listed in `signing.xml` but since this is a Code (and not just Visual Studio) extension, it comes back as an unrecognized file format when being signed.
andyleejordan
force-pushed
the
andschwa/esrp
branch
from
61e800d to
73879c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a bunch of internal stuff to use "ESRP" signing instead of "Package ES" signing, which only matters to Microsoft folks.
Just like PowerShell/PowerShellEditorServices#1408 but downstream.
Resolves #3160.